Updated badges with integrated transitional spinners #2742
Conversation
benjaminleonard
commented
Mar 4, 2025
benjaminleonard
commented
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This no longer has the tooltip for when the page auto updates, but I think if we re-add it should be added to the auto-refresh menu instead. |
|
Looks great. I kinda miss the tooltip on the badge. It's moving, it demands to be hovered on. I'm like a dog seeing a squirrel. I forgot about this one, which is still there: 
|
I was thinking we'd switch to the dropdown auto refresh. Maybe we can put it in the dropdown so if anyone ever clicks it open because they are curious about the frequency of the refresh it's displayed there. |
|
Whilst I'm im there – handling disk and snapshot states.
|
benjaminleonard
changed the title
| await expect(page.getByRole('option', { name: 'disk-0001' })).toBeVisible() | ||
| await expect(page.getByRole('option', { name: 'disk-0002' })).toBeVisible() | ||
| await expect(page.getByRole('option', { name: 'disk-1000' })).toBeVisible() | ||
| await expect(page.getByRole('option', { name: 'disk-0005' })).toBeVisible() |
There was a problem hiding this comment.
After seeding the disks with a mix of states, not all of the previous items were visible. Now the random numbers are deterministic, and so the same disks should be available each time – the only way I can see this breaking is if we fiddle with the Rando numbers.
Personal preference is that they look better without the underscores, and since we're already upper-casing them, I don't (personally) see them and think "these are exact maps to API responses", though I don't have a strong feeling on it. |
|
Definitely kill the underscores. I'm not sure all of those should get spinners — they're not all transitional in the sense of intended to be temporary and automatically moved to another state like with the instance states. A disk can be in importing from bulk writes forever. |
|
This is ready for review – I think switching from a refresh button to an interval picker is best done in a follow up PR. It requires some changes to the interval picker component. |
