[WIP] - Contacts, etc. #2242
Draft
[WIP] - Contacts, etc. #2242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- unorganized amalgamation of cc logic - session-related logic still local
dr7ana
force-pushed
the
contacts
branch
2 times, most recently
from
bfd6006 to
f6376b4
Compare
- DRYing out message serialization across path message types
dr7ana
force-pushed
the
contacts
branch
3 times, most recently
from
2b0f8d3 to
7d3df28
Compare
dr7ana
force-pushed
the
contacts
branch
4 times, most recently
from
ac8feb1 to
e910b2d
Compare
- path mapping fundamentally changed in path_handler and path_context to be correctly 1:1 with upstream RX - concepts of "is_relayed" and "relay_order" made redundant by relay full mesh
With this in the config:
[bind]
listen=144.76.164.202:1666
I was getting a failure during config parsing:
Dec 04 16:00:21 fenrir lokinet[2480391]: [2024-12-04 20:00:21] [+0.000s] [config:critical|/home/testnet/lokinet/llarp/config/config.cpp:1232] Parsing input: 144.76.164.202:1666
Dec 04 16:00:21 fenrir lokinet[2480391]: [2024-12-04 20:00:21] [+0.000s] [config:critical|/home/testnet/lokinet/llarp/config/config.cpp:1234] Parsed input =
Dec 04 16:00:21 fenrir lokinet[2480391]: [1B blob data]
Dec 04 16:00:21 fenrir lokinet[2480391]: :1666
which turned out to be that we had a string view viewing a temporary
std::string. This fixes it.
Also removes a counterproductive `static` from inlined header methods
around addr parsing. (Having a `static` free function forces a distinct
copy of the function to exist for every compilation unit that uses the
function *without* linkage of those functions, while plain `inline`
still compiles separate copies where used, but allows the linker to
deduplicate them when linking the final binary).
dr7ana
force-pushed
the
contacts
branch
3 times, most recently
from
2bdac61 to
36a5e57
Compare
dr7ana
force-pushed
the
contacts
branch
10 times, most recently
from
836933a to
ac210c3
Compare
dr7ana
force-pushed
the
contacts
branch
2 times, most recently
from
bdab0cf to
1f0f053
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.