Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(traverse): remove unnecessary #[allow] #8518

Merged

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Jan 15, 2025

Pure refactor. Remove unnecessary #[allow] attrs. Replace remaining ones with #[expect].

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Jan 15, 2025
Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel force-pushed the 01-15-refactor_traverse_remove_unnecessary_allow_ branch from f69269f to b2800c8 Compare January 15, 2025 17:27
@overlookmotel overlookmotel marked this pull request as ready for review January 15, 2025 17:30
Copy link

codspeed-hq bot commented Jan 15, 2025

CodSpeed Performance Report

Merging #8518 will not alter performance

Comparing 01-15-refactor_traverse_remove_unnecessary_allow_ (04bc259) with main (209e313)

Summary

✅ 32 untouched benchmarks

@overlookmotel
Copy link
Contributor Author

No substantive changes, just tidy-up, so merging without review.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Jan 15, 2025
Copy link
Contributor Author

overlookmotel commented Jan 15, 2025

Merge activity

  • Jan 15, 12:37 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 15, 12:37 PM EST: A user added this pull request to the Graphite merge queue.
  • Jan 15, 12:42 PM EST: A user merged this pull request with the Graphite merge queue.

Pure refactor. Remove unnecessary `#[allow]` attrs. Replace remaining ones with `#[expect]`.
@overlookmotel overlookmotel force-pushed the 01-15-refactor_traverse_remove_unnecessary_allow_ branch from b2800c8 to 04bc259 Compare January 15, 2025 17:38
@graphite-app graphite-app bot merged commit 04bc259 into main Jan 15, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 01-15-refactor_traverse_remove_unnecessary_allow_ branch January 15, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant