Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ast, span, syntax, regular_expression)!: remove ContentHash #8512

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Jan 15, 2025

#8483 removed codegen-ed impls of ContentHash for AST nodes, because ContentHash is not useful. Complete the removal by removing ContentHash trait definition, and all remaining references to it.

@github-actions github-actions bot added the A-ast Area - AST label Jan 15, 2025
Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review January 15, 2025 14:59
@overlookmotel overlookmotel changed the title feat!(ast, span, syntax, regular_expression): remove ContentHash feat(ast, span, syntax, regular_expression)!: remove ContentHash Jan 15, 2025
@github-actions github-actions bot added the C-enhancement Category - New feature or request label Jan 15, 2025
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jan 15, 2025
Copy link
Member

Boshen commented Jan 15, 2025

Merge activity

  • Jan 15, 10:00 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 15, 10:01 AM EST: A user added this pull request to the Graphite merge queue.
  • Jan 15, 10:06 AM EST: A user merged this pull request with the Graphite merge queue.

…8512)

#8483 removed codegen-ed impls of `ContentHash` for AST nodes, because `ContentHash` is not useful. Complete the removal by removing `ContentHash` trait definition, and all remaining references to it.
@Boshen Boshen force-pushed the 01-15-feat_ast_span_syntax_regular_expression_remove_contenthash_ branch from bb43912 to 7066d1c Compare January 15, 2025 15:01
@graphite-app graphite-app bot merged commit 7066d1c into main Jan 15, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 01-15-feat_ast_span_syntax_regular_expression_remove_contenthash_ branch January 15, 2025 15:06
Copy link

codspeed-hq bot commented Jan 15, 2025

CodSpeed Performance Report

Merging #8512 will not alter performance

Comparing 01-15-feat_ast_span_syntax_regular_expression_remove_contenthash_ (7066d1c) with main (a368726)

Summary

✅ 32 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-ast Area - AST C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants