Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transformer/typescript): retain TSImportEqualsDeclaration when it is exported #8460

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Jan 13, 2025

Related: #8458

While doing #8459, I found that I forgot to retain TSImportEqualsDeclaration when it's exported.

Copy link
Member Author

Dunqing commented Jan 13, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-bug Category - Bug labels Jan 13, 2025
Copy link

codspeed-hq bot commented Jan 13, 2025

CodSpeed Performance Report

Merging #8460 will not alter performance

Comparing 01-13-fix_transformer_typescript_retain_tsimportequalsdeclaration_when_it_is_exported (92283db) with 01-13-refactor_transformer_typescript_improve_transforming_namespace (779895c)

Summary

✅ 29 untouched benchmarks

@Dunqing Dunqing force-pushed the 01-13-fix_transformer_typescript_retain_tsimportequalsdeclaration_when_it_is_exported branch from 2e6abf9 to 92283db Compare January 13, 2025 11:33
@Dunqing Dunqing requested review from Boshen and removed request for overlookmotel January 13, 2025 11:34
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Jan 14, 2025
Copy link

graphite-app bot commented Jan 14, 2025

Merge activity

  • Jan 14, 4:40 AM EST: A user added this pull request to the Graphite merge queue.
  • Jan 14, 4:40 AM EST: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.
  • Jan 14, 5:55 AM EST: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • Jan 14, 10:55 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 14, 2025
@Boshen Boshen changed the base branch from 01-13-refactor_transformer_typescript_improve_transforming_namespace to graphite-base/8460 January 14, 2025 09:41
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Jan 14, 2025
@Boshen Boshen merged commit a1713b3 into graphite-base/8460 Jan 14, 2025
29 checks passed
@Boshen Boshen deleted the 01-13-fix_transformer_typescript_retain_tsimportequalsdeclaration_when_it_is_exported branch January 14, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants