Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): implement no-nested-ternary rule #8150

Merged
merged 3 commits into from
Dec 27, 2024

Conversation

baseballyama
Copy link
Contributor

Copy link

graphite-app bot commented Dec 27, 2024

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Dec 27, 2024
Copy link

codspeed-hq bot commented Dec 27, 2024

CodSpeed Performance Report

Merging #8150 will not alter performance

Comparing baseballyama:feat/lint/no-nested-ternary (e43a759) with main (1c5db72)

Summary

✅ 29 untouched benchmarks

@baseballyama
Copy link
Contributor Author

baseballyama commented Dec 27, 2024

I confirmed that I don't use span() in this PR.

related: #8149 (comment)

camc314
camc314 previously approved these changes Dec 27, 2024
@camc314 camc314 dismissed their stale review December 27, 2024 18:05

need to use get_inner_expression

Copy link
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@camc314 camc314 merged commit 5234d96 into oxc-project:main Dec 27, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants