Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(minifier): normalize Infinity into f64::Infinity #8148

Merged

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Dec 27, 2024

No description provided.

@github-actions github-actions bot added A-minifier Area - Minifier C-enhancement Category - New feature or request labels Dec 27, 2024
Copy link
Member Author

Boshen commented Dec 27, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

graphite-app bot commented Dec 27, 2024

Merge activity

  • Dec 27, 11:00 AM EST: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • Dec 28, 1:04 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 28, 1:04 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 28, 1:09 AM EST: A user merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the 12-27-feat_minifier_normalize_infinity_into_f64_infinity_ branch from 18dbaa1 to 0733ddd Compare December 28, 2024 00:39
Copy link

codspeed-hq bot commented Dec 28, 2024

CodSpeed Performance Report

Merging #8148 will not alter performance

Comparing 12-27-feat_minifier_normalize_infinity_into_f64_infinity_ (37c9959) with main (5234d96)

Summary

✅ 29 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Dec 28, 2024
@Boshen Boshen force-pushed the 12-27-feat_minifier_normalize_infinity_into_f64_infinity_ branch from 0733ddd to 37c9959 Compare December 28, 2024 06:05
@graphite-app graphite-app bot merged commit 37c9959 into main Dec 28, 2024
25 checks passed
@graphite-app graphite-app bot deleted the 12-27-feat_minifier_normalize_infinity_into_f64_infinity_ branch December 28, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-minifier Area - Minifier C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant