Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): implement no-lone-blocks rule #8145

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

baseballyama
Copy link
Contributor

@baseballyama baseballyama commented Dec 27, 2024

Copy link

graphite-app bot commented Dec 27, 2024

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Dec 27, 2024
@baseballyama baseballyama force-pushed the feat/lint/no-lone-blocks branch from 6b0ede0 to 8f4c5c8 Compare December 27, 2024 12:14
Copy link

codspeed-hq bot commented Dec 27, 2024

CodSpeed Performance Report

Merging #8145 will not alter performance

Comparing baseballyama:feat/lint/no-lone-blocks (d272fe5) with main (1c5db72)

Summary

✅ 29 untouched benchmarks

@baseballyama
Copy link
Contributor Author

This PR uses span() 4 times but I think we can not convert it to span.

related: #8149 (comment)

@baseballyama baseballyama force-pushed the feat/lint/no-lone-blocks branch from 41327f9 to d272fe5 Compare December 27, 2024 19:44
@baseballyama baseballyama requested a review from camc314 December 27, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants