Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): implement no-labels rule #8131

Merged
merged 2 commits into from
Dec 27, 2024

Conversation

AnsonH
Copy link
Contributor

@AnsonH AnsonH commented Dec 26, 2024

Description

Implements eslint/no-labels rule.

Part of #479

This is my first time contributing to the oxc codebase, so appreciate any comments 🙇

Copy link

graphite-app bot commented Dec 26, 2024

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Dec 26, 2024
Copy link
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@AnsonH
Copy link
Contributor Author

AnsonH commented Dec 27, 2024

(Noob question) I saw that the CI status is stuck at "waiting for approval". Wanna ask do I need to anything special?

image

@camc314
Copy link
Contributor

camc314 commented Dec 27, 2024

Running now. apologies, didn't notice the first time

Copy link

codspeed-hq bot commented Dec 27, 2024

CodSpeed Performance Report

Merging #8131 will not alter performance

Comparing AnsonH:feat/linter/no_labels (f9658a6) with main (ad61e70)

Summary

✅ 29 untouched benchmarks

@camc314 camc314 merged commit 1c5db72 into oxc-project:main Dec 27, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants