Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(minifier): only constant fold numbers when result is smaller #8092

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Dec 24, 2024

No description provided.

@github-actions github-actions bot added A-minifier Area - Minifier C-enhancement Category - New feature or request labels Dec 24, 2024
Copy link
Member Author

Boshen commented Dec 24, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Boshen Boshen marked this pull request as draft December 24, 2024 07:42
Copy link

codspeed-hq bot commented Dec 24, 2024

CodSpeed Performance Report

Merging #8092 will not alter performance

Comparing 12-24-feat_minifier_only_constant_fold_numbers_when_result_is_smaller (22d6072) with main (fccfda9)

Summary

✅ 29 untouched benchmarks

@Boshen Boshen force-pushed the 12-24-feat_minifier_only_constant_fold_numbers_when_result_is_smaller branch from 5f67902 to 22d6072 Compare December 24, 2024 08:20
Copy link
Member Author

Boshen commented Dec 24, 2024

Merge activity

  • Dec 24, 9:34 AM EST: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-minifier Area - Minifier C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant