Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(binder): bind declare class #8038

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ShuiRuTian
Copy link
Contributor

Fix #7278

Copy link

graphite-app bot commented Dec 20, 2024

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the A-semantic Area - Semantic label Dec 20, 2024
Copy link

codspeed-hq bot commented Dec 20, 2024

CodSpeed Performance Report

Merging #8038 will not alter performance

Comparing ShuiRuTian:bind-declare-class (5cf6a04) with main (043252d)

Summary

✅ 29 untouched benchmarks

@ShuiRuTian ShuiRuTian changed the title bind declare class fix(binder): bind declare class Dec 20, 2024
@github-actions github-actions bot added the C-bug Category - Bug label Dec 20, 2024
@ShuiRuTian ShuiRuTian marked this pull request as draft December 20, 2024 17:43
@ShuiRuTian
Copy link
Contributor Author

Not that easy, convert to draft for first.

Need to consider about redeclaration(the term used in oxc now)

This should be valid:

declare class CCC { }

function CCC() { }

@Dunqing Dunqing self-assigned this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-semantic Area - Semantic C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No SymbolId for declare class C {}
2 participants