feat(transformer/class-properties): transform super call expression that is inside static prop initializer #7831

Dunqing · 2024-12-13T08:53:09Z

No description provided.

Dunqing · 2024-12-13T08:53:18Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2024-12-13T09:08:57Z

CodSpeed Performance Report

Merging #7831 will not alter performance

_{Comparing 12-13-feat_transformer_class-properties_transform_super_call_expression_that_is_inside_static_prop_initializer (6bc530d) with main (4920c6a)}

Summary

✅ 29 untouched benchmarks

overlookmotel

Pushed 3 commits with small things.

@Dunqing Going to merge and Github will squash the commits, so I've put them on overlookmotel/7831-unsquashed branch if you want to see what I did. Please delete that branch after you've looked at it (if you want to).

One note: If I buy a dog, then I am the "owner" of the dog. The dog is "owned" by me. So owned_arguments is a better description than arguments_owner here. We have taken ownership of the arguments, like I took ownership of the dog, so the arguments are "owned".

overlookmotel · 2024-12-13T13:46:59Z

Merge activity

Dec 13, 8:46 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Dec 13, 8:47 AM EST: A user added this pull request to the Graphite merge queue.
Dec 13, 8:52 AM EST: A user merged this pull request with the Graphite merge queue.

…hat is inside static prop initializer (#7831)

Shorten code by using `Expression::is_super`, which was introduced in #7831.

Dunqing · 2024-12-13T14:40:27Z

One note: If I buy a dog, then I am the "owner" of the dog. The dog is "owned" by me. So owned_arguments is a better description than arguments_owner here. We have taken ownership of the arguments, like I took ownership of the dog, so the arguments are "owned".

Thanks for describing this, it's useful for me!

Simplify code by using `Expression::is_super` which was introduced in #7831. Also remove a lifetime bound which is unnecessary and replace use of `bool::then` (which I always find hard to read) with more explicit code.

Shorten code by using `Expression::is_super`, which was introduced in #7831.

…#7855) If I understand #7831 correctly, `owned_*` are better here

…7858) Follow-on after #7831. `transform_super_call_expression_arguments` is only used within this file, so does not need to be `pub(super)`.

Follow-on after #7831. Previously this code was: 1. Create a new empty `Vec` (in `move_vec` call). 2. Consume the old `Vec` and create a new `Vec<ArrayExpressionElement>`. 3. Push to the empty `Vec` created in step 1. Instead: 1. Drain the old `Vec` and create a new `Vec<ArrayExpressionElement>`. 2. The old `Vec` is now empty, but still holds an allocation if it wasn't empty before. 3. Push to the old `Vec` (re-using the existing allocation). i.e. We create 1 less `Vec`, and re-use an existing allocation if possible.

…pression_for_super_member_expr` (#7859) Follow-on after #7831. Break up `transform_call_expression_for_super_member_expr` into multiple functions, to make `transform_call_expression_for_super_member_expr` as small as possible, to encourage inlining it.

## [0.42.0] - 2024-12-18 - 84b75a0 semantic: [**BREAKING**] Remove `ScopeFlags::Modifiers` (#7935) (overlookmotel) - c071494 semantic: [**BREAKING**] Remove `SymbolTable::rename` method (#7868) (overlookmotel) ### Features - 8b7c5ae ast: Add `AstBuilder::atom_from_cow` (#7974) (overlookmotel) - 46e2e27 data_structures: Implement `Default` for `NonEmptyStack` (#7946) (overlookmotel) - db9e93b mangler: Mangle top level variables (#7907) (翠 / green) - 075bd16 minifier: Fold bitwise operation (#7908) (翠 / green) - c16a851 napi/transform: Add `jsx: 'preserve'` option (#7965) (Boshen) - 81eedb1 parser: 'readonly' type modifier is only permitted on array and tuple literal types. (#7880) (Boshen) - b9322c6 semantic: Re-export all flags and ID types (#7886) (overlookmotel) - c30a982 span: Add `impl From<ArenaString> for Atom` (#7973) (overlookmotel) - 02b653c transformer/class-properties: Do not create temp var for template literal computed key (#7919) (overlookmotel) - feac02e transformer/class-properties: Only rename symbols if necessary (#7896) (overlookmotel) - 6bc530d transformer/class-properties: Transform super call expression that is inside static prop initializer (#7831) (Dunqing) - 53e2bc0 traverse: Add `TraverseScoping::rename_symbol` method (#7871) (overlookmotel) ### Bug Fixes - 3659e6d cfg: Include export default code in CFG instructions (#7862) (Jan Olaf Martin) - 850dd43 codegen: Missing `,` when generating type parameters with jsx (#7929) (Dunqing) - 4799471 minfier: Bigint bitwise operation only works with bigint (#7937) (Boshen) - de8a86e minifier: Incorrect minification in `try_fold_left_child_op` (#7949) (翠 / green) - 9a30910 oxc_transformer: Inject_global_variables should considering string imported name (#7768) (IWANABETHATGUY) - 111dc52 parser: Include export token in spans of TSNamespaceExportDeclaration (#7963) (branchseer) - 14c51ff semantic: Remove inherting `ScopeFlags::Modifier` from parent scope (#7932) (Dunqing) - 596aead semantic: Reset references flags when resolved (#7923) (Dunqing) - 4924073 semantic: `ScopeTree::rename_binding` preserve order of bindings (#7870) (overlookmotel) - bb38065 transformer/class-properties: Do not transform `super.prop` in nested method within static prop initializer (#7978) (overlookmotel) - e76fbb0 transformer/class-properties: Fix symbol clashes in instance prop initializers (#7872) (overlookmotel) - c0576fa transformer/class-properties: Use UID for `args` in created class constructor (#7866) (overlookmotel) - d660d8d transformer/optional-chaining: Do not create unused reference when `noDocumentAll` assumption (#7847) (overlookmotel) - 4920c6a transformer/optional-chaining: Avoid creating a useless reference when `noDocumentAll` is true (#7832) (Dunqing) ### Performance - a5f04a7 ast: Faster `Comment::is_jsdoc` (#7905) (overlookmotel) - 4b24335 codegen: Improve printing of statement comments (#7857) (Boshen) - 71a40a2 codegen: Guard comment printing comments when there are no comments (#7856) (Boshen) - b31f123 transformer/class-properties: Do not re-generate same method key (#7915) (overlookmotel) - 8ca8fce transformer/class-properties: Reduce work updating scopes when transforming static prop initializers (#7904) (overlookmotel) - 80d0b3e transformer/class-properties: Fast path for instance prop initializer scope re-parenting (#7901) (overlookmotel) - 38aafa2 transformer/class-properties: Reduce size of `transform_call_expression_for_super_member_expr` (#7859) (overlookmotel) ### Documentation - e49de81 ast: Document `Expression::is_*` methods (#7853) (overlookmotel) - 10a86b9 transformer: Fix comments (#7925) (overlookmotel) - f4cb5d3 transformer: Clarify comment (#7918) (overlookmotel) - 41a1456 transformer/class-properties: Correct doc comments (#7966) (overlookmotel) - 18441af transformer/class-properties: Remove oudated todo for assignment expression (#7955) (Dunqing) - 1317c00 transformer/class-properties: Clarify doc comments (#7914) (overlookmotel) - 9989b58 transformer/class-properties: Re-order file list in doc comment (#7911) (overlookmotel) - 7390048 transformer/class-properties: Reformat doc comment (#7909) (overlookmotel) ### Refactor - beb982a ast: Use exhaustive match for `Argument` to `ArrayExpressionElement` conversion (#7848) (overlookmotel) - 3858221 global: Sort imports (#7883) (overlookmotel) - 1314c97 minifier: Expose dce as an API instead of an option (#7957) (Boshen) - 6551dfe semantic: Pass `&str` instead of `Cow` (#7972) (overlookmotel) - b8d2bd2 semantic: Move determining references flags for export specifier to `visit_export_named_declaration` (#7924) (Dunqing) - 98d7946 semantic: Import flags and ID types from `oxc_syntax` (#7887) (overlookmotel) - 1cf8f8f semantic: `SymbolTable::set_name` return old name (#7869) (overlookmotel) - 5d42df8 semantic: Use `Expression::is_super` (#7851) (overlookmotel) - 8cf9766 semantic, syntax, wasm: Remove `#![allow(non_snake_case)]` (#7863) (overlookmotel) - d59bbae transformer: Remove unneeded lint `#[allow]` (#7971) (overlookmotel) - 2c94236 transformer: Improve encapsulation of transforms (#7888) (overlookmotel) - 34091b2 transformer: Use `Expression::is_super` (#7852) (overlookmotel) - d4d7bc0 transformer/async-to-generator: Avoid allocating unnecessary `Atom`s (#7975) (overlookmotel) - 2e5ffd3 transformer/class-properties: Store `temp_var_is_created` on `ClassBindings` (#7981) (overlookmotel) - 27cc6da transformer/class-properties: Store `is_declaration` only on `ClassDetails` (#7980) (overlookmotel) - ee282f8 transformer/class-properties: Remove `move_expression`s (#7979) (overlookmotel) - 94b376a transformer/class-properties: Simplify logic for when to create temp binding (#7977) (overlookmotel) - ff9d1b3 transformer/class-properties: Comments about shorter output (#7976) (overlookmotel) - 6fc40f0 transformer/class-properties: Pass `BoundIdentifier`s by reference (#7968) (overlookmotel) - 69eeeea transformer/class-properties: Methods take `&self` where possible (#7967) (overlookmotel) - 98340bb transformer/class-properties: Use stack of `ClassDetails` (#7947) (overlookmotel) - 088dd48 transformer/class-properties: Shorten code (#7913) (overlookmotel) - 544ffbf transformer/class-properties: Split up code into multiple files (#7912) (overlookmotel) - dcaf674 transformer/class-properties: Rename file (#7910) (overlookmotel) - 6243980 transformer/class-properties: Instance prop inits visitor use `Visit` (#7867) (overlookmotel) - eb47d43 transformer/class-properties: Re-use existing `Vec` (#7854) (overlookmotel) - 1380b7b transformer/class-properties: Reduce visibility of method (#7858) (overlookmotel) - 0f5e078 transformer/class-properties: Rename `*_owner` to `owned_*` (#7855) (Dunqing) - 4ea90d4 transformer/react-refresh: Calculate signature key once (#7970) (Dunqing) - 15b9bff transformer/typescript: Reuse `Atom` (#7969) (overlookmotel) ### Styling - fb897f6 data_structures: Add line break (#7882) (overlookmotel) - 7fb9d47 rust: `cargo +nightly fmt` (#7877) (Boshen) ### Testing - 523d48c transformer: Move named test to exports folder (#7922) (Dunqing) - e766051 transformer: Skip test which uses filesystem under miri (#7874) (overlookmotel) - f39e65e transformer: Prevent lint error when running miri (#7873) (overlookmotel) Co-authored-by: Dunqing <[email protected]>

Dunqing requested a review from overlookmotel as a code owner December 13, 2024 08:53

Dunqing mentioned this pull request Dec 13, 2024

feat(ast): implement From<Argument> for ArrayExpressionElement #7830

Merged

github-actions bot added A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request labels Dec 13, 2024

Dunqing force-pushed the 12-13-feat_ast_implement_from_argument_for_arrayexpressionelement branch from 91b44fe to dd068a3 Compare December 13, 2024 09:00

Dunqing force-pushed the 12-13-feat_transformer_class-properties_transform_super_call_expression_that_is_inside_static_prop_initializer branch from ac51643 to f889e47 Compare December 13, 2024 09:00

github-actions bot added the A-ast Area - AST label Dec 13, 2024

Dunqing force-pushed the 12-13-feat_transformer_class-properties_transform_super_call_expression_that_is_inside_static_prop_initializer branch from f889e47 to 4f2fd6b Compare December 13, 2024 09:01

Dunqing force-pushed the 12-13-feat_ast_implement_from_argument_for_arrayexpressionelement branch from 54cfe22 to e66c18d Compare December 13, 2024 09:34

Dunqing force-pushed the 12-13-feat_transformer_class-properties_transform_super_call_expression_that_is_inside_static_prop_initializer branch from 4f2fd6b to e818a7c Compare December 13, 2024 09:34

Dunqing force-pushed the 12-13-feat_ast_implement_from_argument_for_arrayexpressionelement branch from e66c18d to 84114bd Compare December 13, 2024 09:36

Dunqing force-pushed the 12-13-feat_transformer_class-properties_transform_super_call_expression_that_is_inside_static_prop_initializer branch from e818a7c to 373382a Compare December 13, 2024 09:36

overlookmotel changed the base branch from 12-13-feat_ast_implement_from_argument_for_arrayexpressionelement to graphite-base/7831 December 13, 2024 11:56

Boshen force-pushed the graphite-base/7831 branch from 84114bd to 6466a4a Compare December 13, 2024 13:18

Boshen force-pushed the 12-13-feat_transformer_class-properties_transform_super_call_expression_that_is_inside_static_prop_initializer branch from 373382a to 1a42056 Compare December 13, 2024 13:18

Boshen changed the base branch from graphite-base/7831 to main December 13, 2024 13:19

Boshen force-pushed the 12-13-feat_transformer_class-properties_transform_super_call_expression_that_is_inside_static_prop_initializer branch from 1a42056 to f71d8e4 Compare December 13, 2024 13:19

overlookmotel approved these changes Dec 13, 2024

View reviewed changes

overlookmotel added the 0-merge Merge with Graphite Merge Queue label Dec 13, 2024

feat(transformer/class-properties): transform super call expression t…

6bc530d

…hat is inside static prop initializer (#7831)

overlookmotel force-pushed the 12-13-feat_transformer_class-properties_transform_super_call_expression_that_is_inside_static_prop_initializer branch from 0e9e8f7 to 6bc530d Compare December 13, 2024 13:47

graphite-app bot merged commit 6bc530d into main Dec 13, 2024
26 checks passed

graphite-app bot deleted the 12-13-feat_transformer_class-properties_transform_super_call_expression_that_is_inside_static_prop_initializer branch December 13, 2024 13:52

This was referenced Dec 13, 2024

refactor(linter): use Expression::is_super #7850

Merged

refactor(semantic): use Expression::is_super #7851

Merged

refactor(transformer): use Expression::is_super #7852

Merged

refactor(transformer/class-properties): re-use existing Vec #7854

Merged

Dunqing pushed a commit that referenced this pull request Dec 13, 2024

refactor(semantic): use Expression::is_super (#7851)

5d42df8

Shorten code by using `Expression::is_super`, which was introduced in #7831.

Dunqing mentioned this pull request Dec 13, 2024

refactor(transformer/class-properties): rename *_owner to owned_* #7855

Merged

Dunqing pushed a commit that referenced this pull request Dec 13, 2024

refactor(transformer): use Expression::is_super (#7852)

34091b2

Shorten code by using `Expression::is_super`, which was introduced in #7831.

This was referenced Dec 13, 2024

refactor(transformer/class-properties): reduce visibility of method #7858

Merged

perf(transformer/class-properties): reduce size of transform_call_expression_for_super_member_expr #7859

Merged

overlookmotel pushed a commit that referenced this pull request Dec 13, 2024

refactor(transformer/class-properties): rename *_owner to owned_* (…

0f5e078

…#7855) If I understand #7831 correctly, `owned_*` are better here

overlookmotel mentioned this pull request Dec 14, 2024

Remaining problems for class properties transform #7730

Open

17 tasks

oxc-bot mentioned this pull request Dec 18, 2024

release(crates): v0.42.0 #7983

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(transformer/class-properties): transform super call expression that is inside static prop initializer #7831

feat(transformer/class-properties): transform super call expression that is inside static prop initializer #7831

Dunqing commented Dec 13, 2024

Dunqing commented Dec 13, 2024 •

edited

Loading

codspeed-hq bot commented Dec 13, 2024 •

edited

Loading

overlookmotel left a comment •

edited

Loading

overlookmotel commented Dec 13, 2024 •

edited by graphite-app bot

Loading

Dunqing commented Dec 13, 2024

feat(transformer/class-properties): transform super call expression that is inside static prop initializer #7831

feat(transformer/class-properties): transform super call expression that is inside static prop initializer #7831

Conversation

Dunqing commented Dec 13, 2024

Dunqing commented Dec 13, 2024 • edited Loading

How to use the Graphite Merge Queue

codspeed-hq bot commented Dec 13, 2024 • edited Loading

CodSpeed Performance Report

Merging #7831 will not alter performance

Summary

overlookmotel left a comment • edited Loading

Choose a reason for hiding this comment

overlookmotel commented Dec 13, 2024 • edited by graphite-app bot Loading

Merge activity

Dunqing commented Dec 13, 2024

Dunqing commented Dec 13, 2024 •

edited

Loading

codspeed-hq bot commented Dec 13, 2024 •

edited

Loading

overlookmotel left a comment •

edited

Loading

overlookmotel commented Dec 13, 2024 •

edited by graphite-app bot

Loading