fix(linter): Fix unicorn/prefer-query-selector to use the correct replacement for getElementsByClassName #7796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lacement for getElementsByClassName
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
CodSpeed Performance ReportMerging #7796 will not alter performanceComparing Summary
|
Boshen
reviewed
Dec 11, 2024
camc314
approved these changes
Dec 11, 2024
Boshen
added a commit
that referenced
this pull request
Dec 13, 2024
## [0.15.1] - 2024-12-13 ### Features - 38b1c2e editor: Create a command to apply all auto-fixes for the current active text editor (#7672) (Nicholas Rayburn) ### Bug Fixes - 2b187e5 linter: Fix configuration casing for `typescript/no_this_alias` (#7836) (Boshen) - 06e6d38 linter: Fix unicorn/prefer-query-selector to use the correct replacement for getElementsByClassName (#7796) (Nicholas Rayburn) - 7a83230 semantic: Missing reference when `export default` references a type alias binding (#7813) (Dunqing) Co-authored-by: Boshen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This uses a regex to replace multiple instances of whitespace with
.. May not be the most performant, so if there's a simple alternative I can change to that instead.cc @camc314, I know this was assigned to you but I just wanted to throw something quick together while I had a minute. Feel free to use this, or decline it and write your own.
Fixes #7794.