refactor(transformer): duplicate_expression take mutated_symbol_needs_temp_var param
#7756
+30
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This was referenced Dec 9, 2024
github-actions
bot
added
A-transformer
CodSpeed Performance ReportMerging #7756 will improve performances by 3.27%Comparing Summary
Benchmarks breakdown
|
Merge activity
|
…eds_temp_var` param (#7756) `TransformCtx::duplicate_expression` method introduced in #7754 take a param `mutated_symbol_needs_temp_var`. If `true`, `duplicate_expression` will create a temp var for an `IdentifierReference` whose's symbol is assigned to elsewhere in the AST. If `false`, it won't. This is required because different transforms which use `duplicate_expression` have different requirements.
Dunqing
force-pushed
the
12-09-feat_semantic_add_symboltable_symbol_is_mutated_method
branch
from
99542f4 to
78dff7d
Compare
Dunqing
force-pushed
the
12-09-refactor_transformer_duplicate_expression_take_mutated_symbol_needs_temp_var_param
branch
from
04f6445 to
a750ebc
Compare
Base automatically changed from
12-09-feat_semantic_add_symboltable_symbol_is_mutated_method
to
main
December 10, 2024 02:45
graphite-app
bot
deleted the
12-09-refactor_transformer_duplicate_expression_take_mutated_symbol_needs_temp_var_param
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TransformCtx::duplicate_expressionmethod introduced in #7754 take a parammutated_symbol_needs_temp_var.If
true,duplicate_expressionwill create a temp var for anIdentifierReferencewhose's symbol is assigned to elsewhere in the AST. Iffalse, it won't.This is required because different transforms which use
duplicate_expressionhave different requirements.