Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(isolated_declarations): use NONE in AST builder calls #7752

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Dec 9, 2024

Pure refactor. NONE is shorter than None::<TSTypeAnnotation<'a>>.

Copy link

graphite-app bot commented Dec 9, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-isolated-declarations Isolated Declarations label Dec 9, 2024
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Dec 9, 2024
@overlookmotel overlookmotel marked this pull request as ready for review December 9, 2024 16:29
@overlookmotel
Copy link
Contributor Author

Trivial change, so merging without review.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Dec 9, 2024
@overlookmotel overlookmotel removed the request for review from Dunqing December 9, 2024 16:30
Copy link
Contributor Author

overlookmotel commented Dec 9, 2024

Merge activity

  • Dec 9, 11:30 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 9, 11:32 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 9, 11:41 AM EST: A user merged this pull request with the Graphite merge queue.

Copy link

codspeed-hq bot commented Dec 9, 2024

CodSpeed Performance Report

Merging #7752 will not alter performance

Comparing 12-09-refactor_isolated_declarations_use_none_in_ast_builder_calls (3c1b2bf) with main (75ba4a9)

Summary

✅ 29 untouched benchmarks

Pure refactor. `NONE` is shorter than `None::<TSTypeAnnotation<'a>>`.
@overlookmotel overlookmotel force-pushed the 12-09-refactor_isolated_declarations_use_none_in_ast_builder_calls branch from 1dcd890 to 3c1b2bf Compare December 9, 2024 16:36
@graphite-app graphite-app bot merged commit 3c1b2bf into main Dec 9, 2024
25 checks passed
@graphite-app graphite-app bot deleted the 12-09-refactor_isolated_declarations_use_none_in_ast_builder_calls branch December 9, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-isolated-declarations Isolated Declarations C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant