Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transformer/class-properties): output is not the same with Babel when callee has optional #7748

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Dec 9, 2024

Part of #7749. It is just an output mismatch problem, not affecting runtime behavior.

Copy link

graphite-app bot commented Dec 9, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

codspeed-hq bot commented Dec 9, 2024

CodSpeed Performance Report

Merging #7748 will not alter performance

Comparing 12-09-fix_transformer_class-properties_output_is_not_the_same_with_babel_when_callee_has_optional (f52b1db) with main (cf2ee06)

Summary

✅ 29 untouched benchmarks

@Dunqing Dunqing force-pushed the 12-09-fix_transformer_class-properties_output_is_not_the_same_with_babel_when_callee_has_optional branch from b514687 to cdf5eae Compare December 10, 2024 07:50
@Dunqing Dunqing marked this pull request as ready for review December 10, 2024 09:14
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Dec 10, 2024
Copy link

graphite-app bot commented Dec 10, 2024

Merge activity

…when callee has optional (#7748)

Part of #7749. It is just an output mismatch problem, not affecting runtime behavior.
@overlookmotel overlookmotel force-pushed the 12-09-fix_transformer_class-properties_output_is_not_the_same_with_babel_when_callee_has_optional branch from cdf5eae to f52b1db Compare December 10, 2024 10:35
@graphite-app graphite-app bot merged commit f52b1db into main Dec 10, 2024
25 checks passed
@graphite-app graphite-app bot deleted the 12-09-fix_transformer_class-properties_output_is_not_the_same_with_babel_when_callee_has_optional branch December 10, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants