perf(traverse): faster TraverseScoping::is_static

[overlookmotel]

Speed up TraverseScoping::is_static by checking if symbol is const. That check is faster than iterating through all references to see if they write to the binding.

This also subtly changes behavior. is_static(x) will now return true for x in const x = 1; x = 2;. But that's valid, because the purpose of is_static is to say whether the value of the var can be mutated, which it can't if it's const.

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[overlookmotel]

• perf(traverse): faster TraverseScoping::is_static #7746 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #7746 will not alter performance

_{Comparing 12-09-perf_traverse_faster_traversescoping_is_static_ (9a5ca7b) with main (463fc5f)}

Summary

✅ 29 untouched benchmarks

[overlookmotel]

0.1% perf boost. Woo hoo!

[overlookmotel]

Actually, I'm refactoring things. This method can be deleted entirely. I'll do that in another PR.