Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(transformer/class-properties): add more tests #7743

Merged

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Dec 9, 2024

Babel's tests only cover transforming this.#prop &&= value with logical assignment operators transform also enabled. Add tests for just class properties transform alone.

Copy link

graphite-app bot commented Dec 9, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

overlookmotel commented Dec 9, 2024

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Dec 9, 2024
@overlookmotel overlookmotel marked this pull request as ready for review December 9, 2024 14:12
@overlookmotel
Copy link
Contributor Author

Only adds tests, so merging without review.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Dec 9, 2024
Copy link
Contributor Author

overlookmotel commented Dec 9, 2024

Merge activity

  • Dec 9, 9:15 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 9, 9:23 AM EST: A user merged this pull request with the Graphite merge queue.

Babel's tests only cover transforming `this.#prop &&= value` with logical assignment operators transform also enabled. Add tests for just class properties transform alone.
@overlookmotel overlookmotel force-pushed the 12-09-test_transformer_class-properties_add_more_tests branch from a61e9be to 97acd88 Compare December 9, 2024 14:17
@graphite-app graphite-app bot merged commit 97acd88 into main Dec 9, 2024
16 checks passed
@graphite-app graphite-app bot deleted the 12-09-test_transformer_class-properties_add_more_tests branch December 9, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-test Category - Testing. Code is missing test cases, or a PR is adding them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant