Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): only resolve esm files for import plugin #7720

Merged

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Dec 7, 2024

closes #7696

cjs files do not work at all.

Copy link

graphite-app bot commented Dec 7, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-linter Area - Linter label Dec 7, 2024
Copy link
Member Author

Boshen commented Dec 7, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-bug Category - Bug label Dec 7, 2024
@Boshen Boshen force-pushed the 12-08-fix_linter_only_resolve_esm_files_for_import_plugin branch from 17efde3 to ad27b20 Compare December 7, 2024 17:30
Copy link

graphite-app bot commented Dec 7, 2024

Merge activity

@graphite-app graphite-app bot merged commit ad27b20 into main Dec 7, 2024
24 checks passed
@graphite-app graphite-app bot deleted the 12-08-fix_linter_only_resolve_esm_files_for_import_plugin branch December 7, 2024 17:36
Copy link

codspeed-hq bot commented Dec 7, 2024

CodSpeed Performance Report

Merging #7720 will not alter performance

Comparing 12-08-fix_linter_only_resolve_esm_files_for_import_plugin (ad27b20) with main (5e6053f)

Summary

✅ 29 untouched benchmarks

Boshen added a commit that referenced this pull request Dec 10, 2024
## [0.15.0] - 2024-12-10

- 39b9c5d linter: [**BREAKING**] Remove unmaintained security plugin
(#7773) (Boshen)

### Features

- 065f7dc linter: Support `expectTypeOf`, `assert` and `assertType` in
`vitest/expect-expect` (#7742) (Yuichiro Yamashita)
- 3d5f0a1 linter/no_restricted_imports: Add the no_restricted_imports
rules (#7629) (Guillaume Piedigrossi)

### Bug Fixes

- ad27b20 linter: Only resolve esm files for import plugin (#7720)
(Boshen)
- 5e6053f linter: False positive in `eslint/yoda` (#7719) (dalaoshu)

### Refactor

- c6a19aa linter: Remove unused `serde` features (#7738) (Boshen)
- b9a2b35 linter: Remove `aho-corasick` (#7718) (Boshen)

### Testing

- 62f0a22 linter: Port `react-jsx-uses-vars` rules to no_unused_vars
(#7731) (Tyler Earls)
- 02f9903 linter: Add regression tests for `import/namespace` (#7723)
(dalaoshu)

Co-authored-by: Boshen <[email protected]>
github-merge-queue bot pushed a commit to rolldown/rolldown that referenced this pull request Dec 11, 2024
### Description

Related to oxc-project/oxc#7720

Changelog:
https://github.com/oxc-project/oxc/releases/tag/oxlint_v0.15.0

The main task is to restore the rule that was temporarily disabled in
#3066.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

linter: the rule import/namespace doesn't handle external dependencies correctly
1 participant