Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transform_conformance): custom reporter for exec test #7715

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Dec 7, 2024

closes #7704

Copy link

graphite-app bot commented Dec 7, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request labels Dec 7, 2024
Copy link
Member Author

Boshen commented Dec 7, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

graphite-app bot commented Dec 7, 2024

Merge activity

@Boshen Boshen force-pushed the 12-07-feat_transform_conformance_custom_reporter_for_exec_test branch from fdfd2bd to 5891166 Compare December 7, 2024 11:25
@graphite-app graphite-app bot merged commit 5891166 into main Dec 7, 2024
25 checks passed
@graphite-app graphite-app bot deleted the 12-07-feat_transform_conformance_custom_reporter_for_exec_test branch December 7, 2024 11:29
Copy link

codspeed-hq bot commented Dec 7, 2024

CodSpeed Performance Report

Merging #7715 will not alter performance

Comparing 12-07-feat_transform_conformance_custom_reporter_for_exec_test (5891166) with main (72eab6c)

Summary

✅ 29 untouched benchmarks

@Dunqing
Copy link
Member

Dunqing commented Dec 7, 2024

I think we should keep the error stack trace, as it is very helpful for testing and debugging.

@overlookmotel
Copy link
Contributor

@Dunqing I agree, but JsonReporter doesn't seem to include stack traces anywhere in output. We'd probably need to write our own reporter from scratch.

@overlookmotel
Copy link
Contributor

Scratch that. #7722 adds stack traces to snapshot.

Dunqing pushed a commit that referenced this pull request Dec 8, 2024
`JsonReporter` which the custom test reporter introduced in #7715 uses does not provide error message in `message` prop, where cause of failure is failing assertions. So tests failing due to failing assertions were omitted from snapshot. Include them.

Also add count of passing tests at top of the snapshot.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove extraneous detail from snapshots for transformer "exec" tests
3 participants