-
-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(transform_conformance): custom reporter for exec test #7715
feat(transform_conformance): custom reporter for exec test #7715
Conversation
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Merge activity
|
fdfd2bd
to
5891166
Compare
CodSpeed Performance ReportMerging #7715 will not alter performanceComparing Summary
|
I think we should keep the error stack trace, as it is very helpful for testing and debugging. |
@Dunqing I agree, but |
Scratch that. #7722 adds stack traces to snapshot. |
`JsonReporter` which the custom test reporter introduced in #7715 uses does not provide error message in `message` prop, where cause of failure is failing assertions. So tests failing due to failing assertions were omitted from snapshot. Include them. Also add count of passing tests at top of the snapshot.
closes #7704