Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(oxc_transformer): share object define reference for ReplaceGlobalDefines #7698

Conversation

IWANABETHATGUY
Copy link
Contributor

@IWANABETHATGUY IWANABETHATGUY commented Dec 6, 2024

Closed #7641

Copy link

graphite-app bot commented Dec 6, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Dec 6, 2024
Copy link
Contributor Author

IWANABETHATGUY commented Dec 6, 2024

@IWANABETHATGUY IWANABETHATGUY changed the title feat: share object define reference for GlobalDefine feat(oxc_transformer): share object define reference for GlobalDefine Dec 6, 2024
@github-actions github-actions bot added the C-enhancement Category - New feature or request label Dec 6, 2024
@IWANABETHATGUY IWANABETHATGUY changed the title feat(oxc_transformer): share object define reference for GlobalDefine feat(oxc_transformer): share object define reference for ReplaceGlobalDefines Dec 6, 2024
Copy link

codspeed-hq bot commented Dec 6, 2024

CodSpeed Performance Report

Merging #7698 will not alter performance

Comparing 12-06-feat_share_object_define_reference_for_globaldefine (0e98d18) with main (f7d41dd)

Summary

✅ 29 untouched benchmarks

@IWANABETHATGUY IWANABETHATGUY force-pushed the 12-06-feat_share_object_define_reference_for_globaldefine branch 2 times, most recently from 629166c to 598a78c Compare December 6, 2024 09:50
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review December 6, 2024 10:04
@IWANABETHATGUY IWANABETHATGUY force-pushed the 12-06-feat_share_object_define_reference_for_globaldefine branch from 598a78c to 01bfaca Compare December 6, 2024 10:04
@overlookmotel overlookmotel changed the base branch from 12-04-fix_overlap_replacement to graphite-base/7698 December 6, 2024 15:26
@overlookmotel
Copy link
Contributor

I'm not very familiar with define plugin. Could someone else review please?

@overlookmotel overlookmotel requested review from Boshen and removed request for overlookmotel December 6, 2024 15:30
@overlookmotel overlookmotel force-pushed the 12-06-feat_share_object_define_reference_for_globaldefine branch from 01bfaca to c5291e0 Compare December 6, 2024 15:33
@overlookmotel overlookmotel changed the base branch from graphite-base/7698 to main December 6, 2024 15:34
@overlookmotel overlookmotel force-pushed the 12-06-feat_share_object_define_reference_for_globaldefine branch from c5291e0 to 0e98d18 Compare December 6, 2024 15:34
@Boshen Boshen self-assigned this Dec 7, 2024
@Boshen
Copy link
Member

Boshen commented Dec 9, 2024

#7641 (comment)

@Boshen Boshen closed this Dec 9, 2024
@IWANABETHATGUY IWANABETHATGUY deleted the 12-06-feat_share_object_define_reference_for_globaldefine branch December 9, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

transformer: define does not share reference for objects
3 participants