perf(transformer/jsx): no string comparisons generating pragma expression #7620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This was referenced Dec 3, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-transformer
CodSpeed Performance ReportMerging #7620 will not alter performanceComparing Summary
|
Merge activity
|
Boshen
force-pushed
the
12-03-refactor_transformer_jsx_pragma_parse_take_a_str_
branch
from
eb8bcdf to
171c635
Compare
Boshen
force-pushed
the
12-03-perf_transformer_jsx_no_string_comparisons_generating_pragma_expression
branch
from
67e3461 to
d7b011f
Compare
…sion (#7620) #7553 introduced support for some unusual JSX pragmas e.g. `this.foo` and `import.meta.foo`. We want to support these to pass tests, but they're very unlikely to be used in practice. Identify these strange patterns when parsing the pragma (which happens only once per file), and encode them as an enum. The removes expensive string comparisons from `Pragma::create_expression` (which is called for every JSX element), and keeps the path for common cases fast.
Boshen
force-pushed
the
12-03-refactor_transformer_jsx_pragma_parse_take_a_str_
branch
from
171c635 to
8ad52be
Compare
Boshen
force-pushed
the
12-03-perf_transformer_jsx_no_string_comparisons_generating_pragma_expression
branch
from
d7b011f to
3b1e63e
Compare
Base automatically changed from
12-03-refactor_transformer_jsx_pragma_parse_take_a_str_
to
main
December 4, 2024 02:56
graphite-app
bot
deleted the
12-03-perf_transformer_jsx_no_string_comparisons_generating_pragma_expression
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7553 introduced support for some unusual JSX pragmas e.g.
this.fooandimport.meta.foo. We want to support these to pass tests, but they're very unlikely to be used in practice.Identify these strange patterns when parsing the pragma (which happens only once per file), and encode them as an enum. The removes expensive string comparisons from
Pragma::create_expression(which is called for every JSX element), and keeps the path for common cases fast.