Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): fix false positives in exhaustive-deps #7615

Merged

Conversation

camc314
Copy link
Contributor

@camc314 camc314 commented Dec 3, 2024

part of #7246

Copy link

graphite-app bot commented Dec 3, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Dec 3, 2024
@camc314 camc314 marked this pull request as ready for review December 3, 2024 15:31
Copy link
Contributor Author

camc314 commented Dec 3, 2024

Copy link

codspeed-hq bot commented Dec 3, 2024

CodSpeed Performance Report

Merging #7615 will degrade performances by 3.21%

Comparing c/12-03-fix_linter_fix_false_positives_in_exhaustive-deps (543df6e) with main (9b803d9)

Summary

❌ 1 regressions
✅ 28 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main c/12-03-fix_linter_fix_false_positives_in_exhaustive-deps Change
semantic[cal.com.tsx] 28.2 ms 29.1 ms -3.21%

Copy link
Member

Boshen commented Dec 3, 2024

Merge activity

  • Dec 3, 6:53 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 3, 6:53 PM EST: A user added this pull request to the Graphite merge queue.
  • Dec 3, 7:01 PM EST: A user merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the c/12-03-fix_linter_fix_false_positives_in_exhaustive-deps branch from 0eb64db to 543df6e Compare December 3, 2024 23:54
@graphite-app graphite-app bot merged commit 543df6e into main Dec 4, 2024
24 checks passed
@graphite-app graphite-app bot deleted the c/12-03-fix_linter_fix_false_positives_in_exhaustive-deps branch December 4, 2024 00:01
@oxc-bot oxc-bot mentioned this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-linter Area - Linter C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants