Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(span): fix clippy warning #7591

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Dec 3, 2024

Fix clippy warning. Only triggers when running clippy in --release mode.

Copy link

graphite-app bot commented Dec 3, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review December 3, 2024 02:06
@overlookmotel
Copy link
Contributor Author

Tiny change and only affects clippy, so merging without review.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Dec 3, 2024
Copy link
Contributor Author

overlookmotel commented Dec 3, 2024

Merge activity

  • Dec 2, 9:07 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 2, 9:20 PM EST: A user added this pull request to the Graphite merge queue.
  • Dec 2, 9:23 PM EST: A user merged this pull request with the Graphite merge queue.

@github-actions github-actions bot added the C-bug Category - Bug label Dec 3, 2024
Fix clippy warning. Only triggers when running clippy in `--release` mode.
@overlookmotel overlookmotel force-pushed the 12-03-fix_span_fix_clippy_warning branch from 2335d77 to b553d6f Compare December 3, 2024 02:19
@graphite-app graphite-app bot merged commit b553d6f into main Dec 3, 2024
25 checks passed
@graphite-app graphite-app bot deleted the 12-03-fix_span_fix_clippy_warning branch December 3, 2024 02:23
Copy link

codspeed-hq bot commented Dec 3, 2024

CodSpeed Performance Report

Merging #7591 will not alter performance

Comparing 12-03-fix_span_fix_clippy_warning (b553d6f) with main (3dc46a8)

Summary

✅ 30 untouched benchmarks

@oxc-bot oxc-bot mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant