Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(syntax): remove ModuleRecord::exported_bindings_duplicated because it is a syntax error #7577

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Dec 2, 2024

No description provided.

Copy link

graphite-app bot commented Dec 2, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-linter Area - Linter A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Dec 2, 2024
Copy link
Member Author

Boshen commented Dec 2, 2024

@Boshen Boshen force-pushed the 12-02-refactor_syntax_remove_modulerecord_because_it_is_a_syntax_error branch from 77ce46b to 67637da Compare December 2, 2024 08:32
Copy link

codspeed-hq bot commented Dec 2, 2024

CodSpeed Performance Report

Merging #7577 will not alter performance

Comparing 12-02-refactor_syntax_remove_modulerecord_because_it_is_a_syntax_error (d476660) with main (17663f5)

Summary

✅ 30 untouched benchmarks

@Boshen Boshen force-pushed the 12-02-refactor_syntax_remove_modulerecord_because_it_is_a_syntax_error branch from 67637da to d93c910 Compare December 2, 2024 08:42
Copy link

graphite-app bot commented Dec 2, 2024

Merge activity

@Boshen Boshen force-pushed the 12-02-refactor_syntax_remove_modulerecord_because_it_is_a_syntax_error branch from d93c910 to d476660 Compare December 2, 2024 08:48
@graphite-app graphite-app bot merged commit d476660 into main Dec 2, 2024
26 checks passed
@graphite-app graphite-app bot deleted the 12-02-refactor_syntax_remove_modulerecord_because_it_is_a_syntax_error branch December 2, 2024 08:52
This was referenced Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant