Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(oxc_transformer): replace_global_define ThisExpression #7443

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

Copy link

graphite-app bot commented Nov 23, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Nov 23, 2024
@IWANABETHATGUY IWANABETHATGUY changed the title feat: replace_global_define this expr feat(oxc_transformer): replace_global_define ThisExpression Nov 23, 2024
@github-actions github-actions bot added the C-enhancement Category - New feature or request label Nov 23, 2024
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review November 23, 2024 16:18
Copy link

codspeed-hq bot commented Nov 23, 2024

CodSpeed Performance Report

Merging #7443 will not alter performance

Comparing 11-24-feat_replace_global_define_this_expr (e9f9e82) with main (8797849)

Summary

✅ 30 untouched benchmarks

@IWANABETHATGUY IWANABETHATGUY force-pushed the 11-24-feat_replace_global_define_this_expr branch from c5c6bd2 to 10477a4 Compare November 24, 2024 04:24
@Boshen
Copy link
Member

Boshen commented Nov 25, 2024

@IWANABETHATGUY I merged in the wrong order, can you rebase?

@IWANABETHATGUY
Copy link
Contributor Author

@IWANABETHATGUY I merged in the wrong order, can you rebase?

ok

@IWANABETHATGUY IWANABETHATGUY force-pushed the 11-24-feat_replace_global_define_this_expr branch from 10477a4 to e5b2ffd Compare November 25, 2024 03:36
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Nov 25, 2024
Copy link
Member

Boshen commented Nov 25, 2024

Merge activity

  • Nov 24, 11:13 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 24, 11:13 PM EST: A user added this pull request to the Graphite merge queue.
  • Nov 24, 11:18 PM EST: A user merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the 11-24-feat_replace_global_define_this_expr branch from e5b2ffd to e9f9e82 Compare November 25, 2024 04:13
@graphite-app graphite-app bot merged commit e9f9e82 into main Nov 25, 2024
26 checks passed
@graphite-app graphite-app bot deleted the 11-24-feat_replace_global_define_this_expr branch November 25, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants