Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(oxc_transformer): ReplaceGlobalDefines for ChainExpr #7433

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

IWANABETHATGUY
Copy link
Contributor

No description provided.

Copy link

graphite-app bot commented Nov 23, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Nov 23, 2024
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@IWANABETHATGUY IWANABETHATGUY changed the title feat: replace_global_define optional chain feat: ReplaceGlobalDefines for ChainExpr Nov 23, 2024
@IWANABETHATGUY IWANABETHATGUY changed the title feat: ReplaceGlobalDefines for ChainExpr feat(oxc_transformer): ReplaceGlobalDefines for ChainExpr Nov 23, 2024
@github-actions github-actions bot added the C-enhancement Category - New feature or request label Nov 23, 2024
Copy link

codspeed-hq bot commented Nov 23, 2024

CodSpeed Performance Report

Merging #7433 will not alter performance

Comparing 11-23-feat_replace_global_define_optional_chain (4bb1dca) with main (d8c0931)

Summary

✅ 30 untouched benchmarks

@IWANABETHATGUY IWANABETHATGUY force-pushed the 11-23-feat_replace_global_define_optional_chain branch from 9702e96 to 2bc063e Compare November 23, 2024 11:12
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review November 23, 2024 11:12
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Nov 23, 2024
Copy link
Member

Boshen commented Nov 23, 2024

Merge activity

  • Nov 23, 10:15 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 23, 10:15 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 23, 10:34 AM EST: A user merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the 11-23-feat_replace_global_define_optional_chain branch from 2bc063e to f2a4b5b Compare November 23, 2024 15:15
@Boshen Boshen force-pushed the 11-23-feat_replace_global_define_optional_chain branch from f2a4b5b to 09af43c Compare November 23, 2024 15:17
@Boshen Boshen force-pushed the 11-23-feat_replace_global_define_optional_chain branch from 09af43c to 64ce858 Compare November 23, 2024 15:19
@Boshen Boshen force-pushed the 11-23-feat_replace_global_define_optional_chain branch from 64ce858 to 4bb1dca Compare November 23, 2024 15:21
@graphite-app graphite-app bot merged commit 4bb1dca into main Nov 23, 2024
26 checks passed
@graphite-app graphite-app bot deleted the 11-23-feat_replace_global_define_optional_chain branch November 23, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants