Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): add the eslint/no_duplicate_imports rule #7309

Merged
merged 8 commits into from
Nov 25, 2024

Conversation

Spoutnik97
Copy link
Contributor

Create the rule
Almost all cases are implemented. Already usable

Copy link

graphite-app bot commented Nov 16, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-linter Area - Linter label Nov 16, 2024
@Spoutnik97 Spoutnik97 changed the title Linter/no duplicate imports feat(linter): add the eslint/no_duplicate_imports rule Nov 16, 2024
@github-actions github-actions bot added the C-enhancement Category - New feature or request label Nov 16, 2024
@Spoutnik97 Spoutnik97 force-pushed the linter/no_duplicate_imports branch from 0bbf025 to 3cdc7fb Compare November 17, 2024 23:11
Copy link

codspeed-hq bot commented Nov 18, 2024

CodSpeed Performance Report

Merging #7309 will not alter performance

Comparing Spoutnik97:linter/no_duplicate_imports (95b33c7) with main (2a5954a)

Summary

✅ 30 untouched benchmarks

@Boshen Boshen requested a review from camc314 November 21, 2024 08:14
@Spoutnik97
Copy link
Contributor Author

@camc314 I fixed the PR. Tell me if everything is ok for you

@Spoutnik97 Spoutnik97 force-pushed the linter/no_duplicate_imports branch from d8a1d44 to 95b33c7 Compare November 25, 2024 20:09
Copy link
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great! apologies for the delay!

Copy link
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@camc314 camc314 merged commit 87c893f into oxc-project:main Nov 25, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants