fix(codegen): fix arithmetic overflow printing unspanned nodes #7292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
overlookmotel
force-pushed
the
11-15-fix_codegen_fix_arithmetic_overflow_printing_unspanned_nodes
branch
from
ca974ad to
59484a8
Compare
CodSpeed Performance ReportMerging #7292 will not alter performanceComparing Summary
|
Merge activity
|
Boshen
pushed a commit
that referenced
this pull request
Nov 15, 2024
Similar to #7289. Check if `span.end` is 0 before doing `span.end - 1`, to prevent arithmetic overflow. Also changed all checks to `span.end > 0`, just for consistency.
Boshen
force-pushed
the
11-15-fix_codegen_fix_arithmetic_overflow_printing_unspanned_nodes
branch
from
59484a8 to
1a5e78a
Compare
Similar to #7289. Check if `span.end` is 0 before doing `span.end - 1`, to prevent arithmetic overflow. Also changed all checks to `span.end > 0`, just for consistency.
Boshen
force-pushed
the
11-15-fix_codegen_fix_arithmetic_overflow_printing_unspanned_nodes
branch
from
1a5e78a to
a0766e6
Compare
graphite-app
bot
deleted the
11-15-fix_codegen_fix_arithmetic_overflow_printing_unspanned_nodes
branch
Dunqing
pushed a commit
that referenced
this pull request
Nov 17, 2024
Similar to #7289. Check if `span.end` is 0 before doing `span.end - 1`, to prevent arithmetic overflow. Also changed all checks to `span.end > 0`, just for consistency.
Dunqing
pushed a commit
that referenced
this pull request
Nov 18, 2024
Similar to #7289. Check if `span.end` is 0 before doing `span.end - 1`, to prevent arithmetic overflow. Also changed all checks to `span.end > 0`, just for consistency.
Dunqing
pushed a commit
that referenced
this pull request
Nov 18, 2024
Similar to #7289. Check if `span.end` is 0 before doing `span.end - 1`, to prevent arithmetic overflow. Also changed all checks to `span.end > 0`, just for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #7289. Check if
span.endis 0 before doingspan.end - 1, to prevent arithmetic overflow.Also changed all checks to
span.end > 0, just for consistency.