Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(minifier): minify one child if statement expression #7230

Merged

Conversation

7086cmd
Copy link
Contributor

@7086cmd 7086cmd commented Nov 10, 2024

Let's view the codspeed result at first.

Copy link

graphite-app bot commented Nov 10, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-minifier Area - Minifier C-enhancement Category - New feature or request labels Nov 10, 2024
Copy link
Contributor Author

7086cmd commented Nov 10, 2024

Copy link

codspeed-hq bot commented Nov 10, 2024

CodSpeed Performance Report

Merging #7230 will not alter performance

Comparing 11-10-feat_minifier_minify_one_child_if_statement_expression (a1495e7) with main (c133693)

Summary

✅ 30 untouched benchmarks

@7086cmd 7086cmd force-pushed the 11-10-feat_minifier_minify_one_child_if_statement_expression branch 2 times, most recently from 85ddb48 to f3f2f12 Compare November 10, 2024 08:46
@Boshen Boshen changed the base branch from 11-09-test_minifier_fix_minimize_condition_tests to graphite-base/7230 November 11, 2024 08:36
@Boshen Boshen force-pushed the 11-10-feat_minifier_minify_one_child_if_statement_expression branch from f3f2f12 to e9862e1 Compare November 11, 2024 08:41
@Boshen Boshen changed the base branch from graphite-base/7230 to main November 11, 2024 08:41
@Boshen Boshen force-pushed the 11-10-feat_minifier_minify_one_child_if_statement_expression branch from e9862e1 to 4ea0205 Compare November 11, 2024 08:41
@7086cmd 7086cmd marked this pull request as ready for review November 11, 2024 09:40
@7086cmd
Copy link
Contributor Author

7086cmd commented Nov 11, 2024

So we can assume it's a problem due to enabling a new peephole, same as #6698, #6266, as mentioned in #7231 (comment).

@Boshen Boshen self-requested a review November 16, 2024 13:51
@Boshen Boshen self-assigned this Nov 16, 2024
@Boshen Boshen force-pushed the 11-10-feat_minifier_minify_one_child_if_statement_expression branch from 4ea0205 to 0ff1977 Compare November 26, 2024 14:36
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Nov 26, 2024
Copy link
Member

Boshen commented Nov 26, 2024

Merge activity

  • Nov 26, 9:36 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 26, 9:37 AM EST: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
  • Nov 26, 9:48 AM EST: A user added this pull request to the Graphite merge queue.

@Boshen Boshen force-pushed the 11-10-feat_minifier_minify_one_child_if_statement_expression branch from 0ff1977 to a1495e7 Compare November 26, 2024 14:36
@Boshen Boshen marked this pull request as draft November 26, 2024 14:38
@Boshen Boshen marked this pull request as ready for review November 26, 2024 14:48
@Boshen Boshen merged commit ac0d25c into main Nov 26, 2024
28 checks passed
@Boshen Boshen deleted the 11-10-feat_minifier_minify_one_child_if_statement_expression branch November 26, 2024 14:48
@oxc-bot oxc-bot mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-minifier Area - Minifier C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants