feat(transformer/async-to-generator): handle this within arrows function
#7074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
github-actions
bot
added
A-transformer
This was referenced Nov 1, 2024
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Dunqing
changed the title
this within arrows function
CodSpeed Performance ReportMerging #7074 will degrade performances by 4.3%Comparing Summary
Benchmarks breakdown
|
Dunqing
force-pushed
the
10-31-perf_transformer_arrow-function_change_to_a_correct_scope_id_when_inserting_this
branch
from
1674cf5 to
ab06cc1
Compare
Dunqing
force-pushed
the
11-02-feat_transformer_async-to-generator_handle_this_within_arrows_function
branch
from
0d94534 to
38c99b6
Compare
Dunqing
force-pushed
the
10-31-perf_transformer_arrow-function_change_to_a_correct_scope_id_when_inserting_this
branch
from
ab06cc1 to
d320f62
Compare
Dunqing
force-pushed
the
11-02-feat_transformer_async-to-generator_handle_this_within_arrows_function
branch
from
38c99b6 to
8094309
Compare
This was referenced Nov 4, 2024
Merged
overlookmotel
pushed a commit
that referenced
this pull request
Nov 4, 2024
…inition`'s value to `exit_function` (#7105) Part of #7074 We need to handle this before the `arrow_function` plugin inserts `_this = this` because, in the `async-to-generator` plugin, we will move the body to an inner generator function. However, we don't want `_this = this` moved to the inner generator function as well. So as long as we move first, and then insert, we can fix this problem. The new semantic error is related to another tricky problem, I will fix it in another PR
no-yan
pushed a commit
to no-yan/oxc
that referenced
this pull request
Nov 5, 2024
…thodDefinition`'s value to `exit_function` (oxc-project#7106) Part of oxc-project#7074 I have mentioned the reason why I need to move this in oxc-project#7105
no-yan
pushed a commit
to no-yan/oxc
that referenced
this pull request
Nov 5, 2024
…/ArrowFunctionConverter (oxc-project#7107) Part of oxc-project#7074 In order can reuse the ability of the `ArrowFunction` plugin, we moved out the implementation to common, then we can use use in other plugins
Dunqing
added a commit
that referenced
this pull request
Nov 6, 2024
…ator` and `async-generator-functions` plugins (#7113) Part of #7074 In async-to-generator and async-generator-functions plugins, we may need to transform the async arrow function to a regular generator function, now we can reuse the ability of the ArrowFunction plugin by enabling `ArrowFunctionConverter`. I will fix semantic errors in the follow-up PR
|
Closing as this PR has split into many PRs and has been merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a poc, I am going to split it into many PRs