Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(transformer): support exec tests in Oxc folder #7030

Merged

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Oct 30, 2024

Fix error when tasks/transform_conformance/tests contains exec tests.

Copy link

graphite-app bot commented Oct 30, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Oct 30, 2024
@github-actions github-actions bot added the C-test Category - Testing. Code is missing test cases, or a PR is adding them label Oct 30, 2024
@overlookmotel overlookmotel marked this pull request as ready for review October 30, 2024 18:49
Copy link

codspeed-hq bot commented Oct 30, 2024

CodSpeed Performance Report

Merging #7030 will not alter performance

Comparing 10-30-test_transformer_support_exec_tests_in_oxc_folder (2a57a66) with main (3d174bb)

Summary

✅ 30 untouched benchmarks

@overlookmotel overlookmotel requested a review from Boshen October 30, 2024 20:00
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Oct 31, 2024
Copy link
Member

Boshen commented Oct 31, 2024

Merge activity

  • Oct 30, 9:17 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 30, 9:17 PM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 30, 9:26 PM EDT: A user merged this pull request with the Graphite merge queue.

Fix error when `tasks/transform_conformance/tests` contains exec tests.
@Boshen Boshen force-pushed the 10-30-test_transformer_support_exec_tests_in_oxc_folder branch from 96a98ba to 2a57a66 Compare October 31, 2024 01:18
@graphite-app graphite-app bot merged commit 2a57a66 into main Oct 31, 2024
28 checks passed
@graphite-app graphite-app bot deleted the 10-30-test_transformer_support_exec_tests_in_oxc_folder branch October 31, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-test Category - Testing. Code is missing test cases, or a PR is adding them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants