-
-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@typescript-eslint/no-namespace #703
@typescript-eslint/no-namespace #703
Conversation
We don't need to lint |
Since the |
In the original rule there is an option |
Let's keep the parsed value and , we just don't use it for now.
Sounds good to me! Maybe keep the |
a7f6f93
to
7f33a4f
Compare
Thank you! Love the addition to rule gen! |
Overview
Fixes the
no-namespace
rule for #503Help needed
Tester
to support running tests with different extensions, so I did the bare minimum and would appreciate guidance how to make it actually good. My current approach is just running a separate test/snapshot for tests that require a different extension. I was thinking adding it inside the optionsjson
, but it seemed unintuitive to use.crates/oxc_semantic/src/builder.rs
, but I'm not sure why it was in the first place.Notes
typescript-eslint
rule generator. Didn't supportfilename
since had trouble adjusting theTester
module.