Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): implement adjacent-overload-signature #578

Merged
merged 6 commits into from
Jul 21, 2023

Conversation

cijiugechu
Copy link
Contributor

@cijiugechu cijiugechu commented Jul 20, 2023

Related issue: #503.
Some notes: these tests are commented because it would raise syntax errors like Identifier "foo" has already been declared, which is beyond the scope of this rule.

@github-actions github-actions bot added the A-linter Area - Linter label Jul 20, 2023
Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the grouped spans!

@Boshen Boshen merged commit 836d430 into oxc-project:main Jul 21, 2023
@Boshen
Copy link
Member

Boshen commented Jul 21, 2023

Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants