Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(linter): move typescript/no-magic-numbers to eslint/no-magic-numbers #5640

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Sep 9, 2024

closes #5614

Copy link
Member Author

Boshen commented Sep 9, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Boshen and the rest of your teammates on Graphite Graphite

Copy link

graphite-app bot commented Sep 9, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-linter Area - Linter label Sep 9, 2024
Copy link

graphite-app bot commented Sep 9, 2024

Merge activity

@Boshen Boshen force-pushed the 09-09-chore_linter_move_typescript_no-magic-numbers_to_eslint_no-magic-numbers branch from 02ee9f2 to 6dcaae5 Compare September 9, 2024 08:53
@graphite-app graphite-app bot merged commit 6dcaae5 into main Sep 9, 2024
24 checks passed
@graphite-app graphite-app bot deleted the 09-09-chore_linter_move_typescript_no-magic-numbers_to_eslint_no-magic-numbers branch September 9, 2024 08:57
Copy link

codspeed-hq bot commented Sep 9, 2024

CodSpeed Performance Report

Merging #5640 will not alter performance

Comparing 09-09-chore_linter_move_typescript_no-magic-numbers_to_eslint_no-magic-numbers (6dcaae5) with main (41582ea)

Summary

✅ 29 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: "typescript/no-magic-numbers" is not marked as supported
1 participant