Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): mark eslint and typescript alias rules as implemented, #4611

Closed
wants to merge 2 commits into from

Conversation

Sysix
Copy link
Contributor

@Sysix Sysix commented Aug 2, 2024

Closes #4085

Copy link

graphite-app bot commented Aug 2, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.


/** @param {import("eslint").Linter} linter */
const loadPluginTypeScriptRules = (linter) => {
// We want to list all rules but not support type-checked rules
const pluginTypeScriptDisableTypeCheckedRules = new Map(
Copy link
Contributor Author

@Sysix Sysix Aug 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont know why this rules were excluded. When I keep this line I get a warning:

👀 typescript/require-await is implemented but not found in their rules

Also this bumps the total rules:

There are 123(+ 26 deprecated) rules.

  • 41/75 recommended rules are remaining as TODO
  • 38/48 not recommended rules are remaining as TODO

@@ -242,6 +285,9 @@ exports.ALL_TARGET_PLUGINS = new Map([
],
["react-perf", { npm: ["eslint-plugin-react-perf"], issueNo: 2041 }],
["nextjs", { npm: ["@next/eslint-plugin-next"], issueNo: 1929 }],
["promise", { npm: ["eslint-plugin-promise"], issueNo: 9999 }], // TODO!
["vitest", { npm: ["eslint-plugin-vitest"], issueNo: 9999 }], // TODO!
["tree-shaking", { npm: ["eslint-plugin-tree-shaking"], issueNo: 9999 }], // TODO!
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tree-shaking has only one rule in node and in oxc.

You should know better if an Tracking-Issue should be created or not ;)

@leaysgur
Copy link
Contributor

leaysgur commented Aug 5, 2024

@Sysix Hey, thanks for the initiative!

Looking at the code diff, it appears that the content and title of the PR do not match?

And I have addressed the part of updating the typescript-eslint status in a separate PR. #4654

Therefore, can I ask you to reduce the scope of this PR to the part that tracks the status of plugin-promise and plugin-vitest? (If plugin-tree-shaking has a single rule, then I don't think tracking is necessary either)

@Boshen Would you please create a ☂️ issue for plugin-promise and plugin-vitest?

Boshen pushed a commit that referenced this pull request Aug 5, 2024
…status (#4654)

Closes #4085 

This issue seemed to have been addressed in #3779 , but partially
reverted in #3813 ? 🤔

Since I wasn't aware of these changes, I've just checked the current
implementation through the review requests in #4611 and refactored as
the original author.
@Sysix
Copy link
Contributor Author

Sysix commented Aug 5, 2024

@leaysgur thanks u, I created another PR: #4668

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some of the rules should be marked as completed in eslint core rules
2 participants