Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add typescript-eslint rule array-type #2292

Merged
merged 18 commits into from
Feb 6, 2024

Conversation

luhc228
Copy link
Contributor

@luhc228 luhc228 commented Feb 4, 2024

Ref: #2180

Most test cases which from eslint-plugin pass, but some don't. At this time I could not figure out. I want to add more test cases after some time.

Copy link

netlify bot commented Feb 4, 2024

Deploy Preview for oxc failed.

Name Link
🔨 Latest commit f7e4234
🔍 Latest deploy log https://app.netlify.com/sites/oxc/deploys/65bf44e5140e9c00087cdf5c

@github-actions github-actions bot added the A-linter Area - Linter label Feb 4, 2024
Copy link

codspeed-hq bot commented Feb 4, 2024

CodSpeed Performance Report

Merging #2292 will not alter performance

⚠️ No base runs were found

Falling back to comparing luhc228:feat/array_type (8358945) with main (6fe9300)

Summary

✅ 27 untouched benchmarks

Copy link
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing a snapshot file?

Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@luhc228
Copy link
Contributor Author

luhc228 commented Feb 6, 2024

clippy error must be fixed before merging pr? @Boshen

@Boshen Boshen merged commit 8771c64 into oxc-project:main Feb 6, 2024
19 checks passed
IWANABETHATGUY pushed a commit to IWANABETHATGUY/oxc that referenced this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants