Skip to content

refactor(traverse): take &str instead of CompactStr in TraverseScoping::rename_symbol #10610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Apr 25, 2025

Scoping no longer needs a CompactStr so into_compact_str is unnecessary.

Copy link
Member Author

Dunqing commented Apr 25, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codspeed-hq bot commented Apr 25, 2025

CodSpeed Instrumentation Performance Report

Merging #10610 will not alter performance

Comparing 04-25-refactor_traverse_take_str_instead_of_compactstr_in_traversescoping_rename_symbol (b31ab87) with main (76ea6a9)

Summary

✅ 36 untouched benchmarks

@Dunqing Dunqing force-pushed the 04-25-refactor_traverse_take_str_instead_of_compactstr_in_traversescoping_rename_symbol branch from 18dc313 to 4a04b8a Compare April 25, 2025 02:52
@Dunqing Dunqing force-pushed the 04-23-perf_traverse_use_arenastring_instead_compactstring_to_stote_uid_name branch from 180aea7 to 1f6b2ac Compare April 25, 2025 02:52
@Dunqing Dunqing marked this pull request as ready for review April 25, 2025 02:54
@Dunqing Dunqing requested a review from overlookmotel as a code owner April 25, 2025 02:54
@Dunqing Dunqing force-pushed the 04-25-refactor_traverse_take_str_instead_of_compactstr_in_traversescoping_rename_symbol branch from b38a02a to 4a04b8a Compare April 25, 2025 07:55
@graphite-app graphite-app bot changed the base branch from 04-23-perf_traverse_use_arenastring_instead_compactstring_to_stote_uid_name to graphite-base/10610 April 27, 2025 02:39
@graphite-app graphite-app bot force-pushed the graphite-base/10610 branch from 1f6b2ac to bdcbeb4 Compare April 27, 2025 02:49
@graphite-app graphite-app bot force-pushed the 04-25-refactor_traverse_take_str_instead_of_compactstr_in_traversescoping_rename_symbol branch from 4a04b8a to ae72876 Compare April 27, 2025 02:49
@graphite-app graphite-app bot changed the base branch from graphite-base/10610 to main April 27, 2025 02:50
@graphite-app graphite-app bot force-pushed the 04-25-refactor_traverse_take_str_instead_of_compactstr_in_traversescoping_rename_symbol branch from ae72876 to c522027 Compare April 27, 2025 02:50
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Apr 27, 2025
Copy link
Contributor

graphite-app bot commented Apr 27, 2025

Merge activity

@Dunqing Dunqing force-pushed the 04-25-refactor_traverse_take_str_instead_of_compactstr_in_traversescoping_rename_symbol branch from c522027 to 62fa7de Compare April 27, 2025 03:23
graphite-app bot pushed a commit that referenced this pull request Apr 27, 2025
…coping::rename_symbol` (#10610)

`Scoping` no longer needs a `CompactStr` so `into_compact_str` is unnecessary.
@graphite-app graphite-app bot force-pushed the 04-25-refactor_traverse_take_str_instead_of_compactstr_in_traversescoping_rename_symbol branch from 62fa7de to dddfdb4 Compare April 27, 2025 03:30
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 27, 2025
…coping::rename_symbol` (#10610)

`Scoping` no longer needs a `CompactStr` so `into_compact_str` is unnecessary.
@Boshen Boshen force-pushed the 04-25-refactor_traverse_take_str_instead_of_compactstr_in_traversescoping_rename_symbol branch from dddfdb4 to b31ab87 Compare April 27, 2025 05:10
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Apr 27, 2025
@graphite-app graphite-app bot merged commit b31ab87 into main Apr 27, 2025
27 checks passed
@graphite-app graphite-app bot deleted the 04-25-refactor_traverse_take_str_instead_of_compactstr_in_traversescoping_rename_symbol branch April 27, 2025 05:21
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants