-
-
Notifications
You must be signed in to change notification settings - Fork 573
refactor(traverse): take &str
instead of CompactStr
in TraverseScoping::rename_symbol
#10610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
graphite-app
merged 1 commit into
main
from
04-25-refactor_traverse_take_str_instead_of_compactstr_in_traversescoping_rename_symbol
Apr 27, 2025
Merged
refactor(traverse): take &str
instead of CompactStr
in TraverseScoping::rename_symbol
#10610
graphite-app
merged 1 commit into
main
from
04-25-refactor_traverse_take_str_instead_of_compactstr_in_traversescoping_rename_symbol
Apr 27, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 25, 2025
CodSpeed Instrumentation Performance ReportMerging #10610 will not alter performanceComparing Summary
|
18dc313
to
4a04b8a
Compare
180aea7
to
1f6b2ac
Compare
b38a02a
to
4a04b8a
Compare
This was referenced Apr 26, 2025
perf(allocator/vec2): replace
self.reserve(1)
calls with self.grow_one()
for better efficiency
#9856
Merged
1f6b2ac
to
bdcbeb4
Compare
4a04b8a
to
ae72876
Compare
ae72876
to
c522027
Compare
Merge activity
|
c522027
to
62fa7de
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Apr 27, 2025
…coping::rename_symbol` (#10610) `Scoping` no longer needs a `CompactStr` so `into_compact_str` is unnecessary.
62fa7de
to
dddfdb4
Compare
…coping::rename_symbol` (#10610) `Scoping` no longer needs a `CompactStr` so `into_compact_str` is unnecessary.
dddfdb4
to
b31ab87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-transformer
Area - Transformer / Transpiler
C-cleanup
Category - technical debt or refactoring. Solution not expected to change behavior
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scoping
no longer needs aCompactStr
sointo_compact_str
is unnecessary.