Skip to content

refactor(napi/parser): move generated deserializer files #10481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Apr 17, 2025

Pure refactor. Move generated deserializer files for napi/parser into a generated/deserialize directory. This is to make room for more generated files (e.g. visitor, more specialized deserializers), without the number of file in root of the package exploding.

@github-actions github-actions bot added the A-ast-tools Area - AST tools label Apr 17, 2025
Copy link
Contributor Author

overlookmotel commented Apr 17, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Apr 17, 2025
@overlookmotel overlookmotel marked this pull request as ready for review April 17, 2025 17:17
@overlookmotel
Copy link
Contributor Author

overlookmotel commented Apr 17, 2025

@Boshen Will the release scripts include files in generated directory in the NPM package? I can't figure out what the Github actions for releases are doing, and for some reason can't get the pnpm napi commands in them to run locally in order to test it.

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Apr 19, 2025
Copy link
Contributor

graphite-app bot commented Apr 19, 2025

Merge activity

graphite-app bot pushed a commit that referenced this pull request Apr 19, 2025
Pure refactor. Move generated deserializer files for `napi/parser` into a `generated/deserialize` directory. This is to make room for more generated files (e.g. visitor, more specialized deserializers), without the number of file in root of the package exploding.
@graphite-app graphite-app bot force-pushed the 04-17-refactor_napi_parser_move_generated_deserializer_files branch from bdab229 to 5a4367e Compare April 19, 2025 14:13
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 19, 2025
@overlookmotel overlookmotel force-pushed the 04-17-refactor_napi_parser_move_generated_deserializer_files branch from 5a4367e to 0368a3a Compare April 22, 2025 09:54
@overlookmotel overlookmotel requested a review from Boshen April 22, 2025 09:57
@Boshen
Copy link
Member

Boshen commented Apr 25, 2025

Conflict.

Pure refactor. Move generated deserializer files for `napi/parser` into a `generated/deserialize` directory. This is to make room for more generated files (e.g. visitor, more specialized deserializers), without the number of file in root of the package exploding.
@overlookmotel overlookmotel force-pushed the 04-17-refactor_napi_parser_move_generated_deserializer_files branch from 0368a3a to 3b6d52d Compare April 29, 2025 09:43
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Apr 29, 2025
@graphite-app graphite-app bot merged commit 3b6d52d into main Apr 29, 2025
14 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 29, 2025
@graphite-app graphite-app bot deleted the 04-17-refactor_napi_parser_move_generated_deserializer_files branch April 29, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants