Skip to content

feat(linter): add eslint/block-scoped-var #10237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 28, 2025

Conversation

huangtiandi1999
Copy link
Contributor

Copy link
Contributor

graphite-app bot commented Apr 4, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@huangtiandi1999 huangtiandi1999 marked this pull request as draft April 4, 2025 15:22
@github-actions github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Apr 4, 2025
Copy link

codspeed-hq bot commented Apr 4, 2025

CodSpeed Instrumentation Performance Report

Merging #10237 will not alter performance

Comparing huangtiandi1999:feat/linter/block-scoped-var (5ae9433) with main (2615758)

Summary

✅ 9 untouched benchmarks
🆕 27 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 codegen[checker.ts] N/A 22.1 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 65.1 ms N/A
🆕 formatter[antd.js] N/A 709.6 ms N/A
🆕 formatter[react.development.js] N/A 8 ms N/A
🆕 formatter[typescript.js] N/A 1.1 s N/A
🆕 mangler[antd.js] N/A 15.9 ms N/A
🆕 mangler[react.development.js] N/A 294.2 µs N/A
🆕 mangler[typescript.js] N/A 39.5 ms N/A
🆕 minifier[antd.js] N/A 163.6 ms N/A
🆕 minifier[react.development.js] N/A 1.8 ms N/A
🆕 minifier[typescript.js] N/A 287.9 ms N/A
🆕 estree[checker.ts] N/A 96.8 ms N/A
🆕 parser[RadixUIAdoptionSection.jsx] N/A 89.2 µs N/A
🆕 parser[antd.js] N/A 105.5 ms N/A
🆕 parser[cal.com.tsx] N/A 29.1 ms N/A
🆕 parser[checker.ts] N/A 53.2 ms N/A
🆕 parser[pdf.mjs] N/A 16.8 ms N/A
🆕 semantic[RadixUIAdoptionSection.jsx] N/A 73.1 µs N/A
🆕 semantic[antd.js] N/A 103.4 ms N/A
🆕 semantic[cal.com.tsx] N/A 25.9 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@huangtiandi1999 huangtiandi1999 marked this pull request as ready for review April 6, 2025 14:07
Copy link
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@camc314
Copy link
Contributor

camc314 commented Apr 28, 2025

i think the perf drop, while not ideal is ok. checker.ts has a lot of var declarations that this rule needs to check, and i can't see any obvious ways to improve the perf of this rule

@camc314 camc314 requested a review from Sysix April 28, 2025 13:09
@Boshen Boshen merged commit a69a0ee into oxc-project:main Apr 28, 2025
30 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants