You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Snapshots for transformer "exec" tests contain extraneous details which make snapshot changes hard to read, and causes erroneous conformance task failures.
Irrelevant details cause CI failures
For example, #7687 adds a new exec test. The problem is that the snapshot contains irrelevant details, which cause changes in the snapshot on every run, and so an erroneous failure:
I'm not sure if we can get vitest to not output these irrelevant details, or whether we'd need to post-process vitest's output to remove them before outputting snapshot.
Test numbering creates large diffs
Snapshots include a number before each test failure e.g.:
⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/28]⎯
This creates a lot of churn in the diff when you fix a test, which makes it harder to see the relevant changes. Because you get a ton of irrelevant changes like:
Snapshots for transformer "exec" tests contain extraneous details which make snapshot changes hard to read, and causes erroneous conformance task failures.
Irrelevant details cause CI failures
For example, #7687 adds a new exec test. The problem is that the snapshot contains irrelevant details, which cause changes in the snapshot on every run, and so an erroneous failure:
https://github.com/oxc-project/oxc/actions/runs/12197559497/job/34027460327?pr=7687
I'm not sure if we can get vitest to not output these irrelevant details, or whether we'd need to post-process vitest's output to remove them before outputting snapshot.
Test numbering creates large diffs
Snapshots include a number before each test failure e.g.:
This creates a lot of churn in the diff when you fix a test, which makes it harder to see the relevant changes. Because you get a ton of irrelevant changes like:
This is not so important, it's just a bit messy.
@Boshen I'm not familiar with vitest, so not sure how best to tackle these.
The text was updated successfully, but these errors were encountered: