fix(linter): false positive in exhaustive-deps (#7626)

oxc-project · Dec 4, 2024 · e824501 · e824501
1 parent 8a68ef4
commit e824501
Showing 1 changed file with 19 additions and 1 deletion.
diff --git a/crates/oxc_linter/src/rules/react/exhaustive_deps.rs b/crates/oxc_linter/src/rules/react/exhaustive_deps.rs
@@ -407,7 +407,10 @@ impl Rule for ExhaustiveDeps {
                         })
                     });
 
-                    if has_write_reference {
+                    if has_write_reference
+                        || get_declaration_from_reference_id(ident.reference_id(), ctx.semantic())
+                            .is_some_and(|decl| decl.scope_id() != component_scope_id)
+                    {
                         continue;
                     }
                 }
@@ -2107,6 +2110,21 @@ fn test() {
         });
     }, [options]);
 }",
+        "export function useCanvasZoomOrScroll() {
+           useEffect(() => {
+               let wheelStopTimeoutId: { current: number | undefined } = { current: undefined };
+       
+               wheelStopTimeoutId = requestAnimationFrameTimeout(() => {
+                   setLastInteraction?.(null);
+               }, 300);
+       
+               return () => {
+                   if (wheelStopTimeoutId.current !== undefined) {
+                       console.log('h1');
+                   }
+               };
+           }, []);
+        }",
     ];
 
     let fail = vec![