-
-
Notifications
You must be signed in to change notification settings - Fork 477
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(linter): implement
no-nested-ternary
rule
- Loading branch information
1 parent
1c5db72
commit b113e8a
Showing
3 changed files
with
86 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,69 @@ | ||
use oxc_ast::ast::Expression; | ||
use oxc_ast::AstKind; | ||
use oxc_diagnostics::OxcDiagnostic; | ||
use oxc_macros::declare_oxc_lint; | ||
use oxc_span::Span; | ||
|
||
use crate::{context::LintContext, rule::Rule, AstNode}; | ||
|
||
fn no_nested_ternary_diagnostic(span: Span) -> OxcDiagnostic { | ||
OxcDiagnostic::warn("Do not nest ternary expressions.").with_label(span) | ||
} | ||
|
||
#[derive(Debug, Default, Clone)] | ||
pub struct NoNestedTernary; | ||
|
||
declare_oxc_lint!( | ||
/// ### What it does | ||
/// | ||
/// Disallows nested ternary expressions to improve code readability and maintainability. | ||
/// | ||
/// ### Why is this bad? | ||
/// | ||
/// Nested ternary expressions make code harder to read and understand. They can lead to complex, difficult-to-debug logic. | ||
/// | ||
/// ### Examples | ||
/// | ||
/// Examples of **incorrect** code for this rule: | ||
/// ```js | ||
/// const result = condition1 ? (condition2 ? "a" : "b") : "c"; | ||
/// ``` | ||
/// | ||
/// Examples of **correct** code for this rule: | ||
/// ```js | ||
/// let result; | ||
/// if (condition1) { | ||
/// result = condition2 ? "a" : "b"; | ||
/// } else { | ||
/// result = "c"; | ||
/// } | ||
/// ``` | ||
NoNestedTernary, | ||
style, | ||
); | ||
|
||
impl Rule for NoNestedTernary { | ||
fn run<'a>(&self, node: &AstNode<'a>, ctx: &LintContext<'a>) { | ||
if let AstKind::ConditionalExpression(node) = node.kind() { | ||
if matches!(node.alternate, Expression::ConditionalExpression(_)) | ||
|| matches!(node.consequent, Expression::ConditionalExpression(_)) | ||
{ | ||
ctx.diagnostic(no_nested_ternary_diagnostic(node.span)); | ||
} | ||
} | ||
} | ||
} | ||
|
||
#[test] | ||
fn test() { | ||
use crate::tester::Tester; | ||
|
||
let pass = vec!["foo ? doBar() : doBaz();", "var foo = bar === baz ? qux : quxx;"]; | ||
|
||
let fail = vec![ | ||
"foo ? bar : baz === qux ? quxx : foobar;", | ||
"foo ? baz === qux ? quxx : foobar : bar;", | ||
]; | ||
|
||
Tester::new(NoNestedTernary::NAME, NoNestedTernary::CATEGORY, pass, fail).test_and_snapshot(); | ||
} |
15 changes: 15 additions & 0 deletions
15
crates/oxc_linter/src/snapshots/eslint_no_nested_ternary.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
--- | ||
source: crates/oxc_linter/src/tester.rs | ||
snapshot_kind: text | ||
--- | ||
⚠ eslint(no-nested-ternary): Do not nest ternary expressions. | ||
╭─[no_nested_ternary.tsx:1:1] | ||
1 │ foo ? bar : baz === qux ? quxx : foobar; | ||
· ─────────────────────────────────────── | ||
╰──── | ||
|
||
⚠ eslint(no-nested-ternary): Do not nest ternary expressions. | ||
╭─[no_nested_ternary.tsx:1:1] | ||
1 │ foo ? baz === qux ? quxx : foobar : bar; | ||
· ─────────────────────────────────────── | ||
╰──── |