-
-
Notifications
You must be signed in to change notification settings - Fork 484
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(tasks): benchmarks for lexer (#2101)
This PR adds benchmarks for the lexer. I'm doing some work on optimizing the lexer and I thought it'd be useful to see the effects of changes in isolation, separate from the parser. These benchmarks may not be ideal to keep long-term, but for now it'd be useful. In order to do so, it's necessary for `oxc_parser` crate to expose the lexer, but have done that without adding it to the docs, and using an alias `__lexer`.
- Loading branch information
1 parent
16b3261
commit 36c718e
Showing
4 changed files
with
60 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
use oxc_allocator::Allocator; | ||
use oxc_benchmark::{criterion_group, criterion_main, BenchmarkId, Criterion}; | ||
use oxc_parser::__lexer::{Kind, Lexer}; | ||
use oxc_span::SourceType; | ||
use oxc_tasks_common::{TestFile, TestFiles}; | ||
|
||
fn bench_lexer(criterion: &mut Criterion) { | ||
let mut group = criterion.benchmark_group("lexer"); | ||
|
||
// Lexer lacks awareness of JS grammar, so it gets confused by a few things without the parser | ||
// driving it, notably escapes in regexps and template strings. | ||
// So simplify the input for it, by removing backslashes and converting template strings to | ||
// normal string literals. | ||
let files = TestFiles::complicated() | ||
.files() | ||
.iter() | ||
.map(|file| TestFile { | ||
url: file.url.clone(), | ||
file_name: file.file_name.clone(), | ||
source_text: file.source_text.replace('\\', " ").replace('`', "'"), | ||
}) | ||
.collect::<Vec<_>>(); | ||
|
||
for file in files { | ||
let source_type = SourceType::from_path(&file.file_name).unwrap(); | ||
group.bench_with_input( | ||
BenchmarkId::from_parameter(&file.file_name), | ||
&file.source_text, | ||
|b, source_text| { | ||
b.iter_with_large_drop(|| { | ||
// Include the allocator drop time to make time measurement consistent. | ||
// Otherwise the allocator will allocate huge memory chunks (by power of two) from the | ||
// system allocator, which makes time measurement unequal during long runs. | ||
let allocator = Allocator::default(); | ||
let mut lexer = Lexer::new(&allocator, source_text, source_type); | ||
while lexer.next_token().kind != Kind::Eof {} | ||
allocator | ||
}); | ||
}, | ||
); | ||
} | ||
group.finish(); | ||
} | ||
|
||
criterion_group!(lexer, bench_lexer); | ||
criterion_main!(lexer); |