fix(lookup_token): should be None if original tokens hasn't the line #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hi-ogawa can you help me review? |
hi-ogawa
reviewed
Dec 11, 2024
hi-ogawa
approved these changes
Dec 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close rolldown/rolldown#3112.
You could see the pervious test
(1000, 0)return(2, 8), it is last token at original mapping, if we add more token exceeding the line, it will always mapping to the last token, it is incorrect.The pr fixed it. Here create
Vec<LineLookupTable>for original tokens, if is easy to check exceeding line, and also has better performance than the previous implement, it only binarySearch the line tokens instead of the all tokens. It inspire from https://github.com/jridgewell/trace-mapping/blob/main/src/trace-mapping.ts#L178