feat: add new portal into runtime to include footer #9815

LukasHirt · 2023-10-16T14:36:54Z

Description

Add a new portal into the application layout of runtime package. This portals allows developers to add new content below the app container. Because of this position, I chose the name footer for the portal. This change also makes the wrapper element of the container a flexbox. This is needed because the view itself has a limited height and this allows us to fit in the footer.

Related Issue

refs [web] Provide Embed Mode for Location and File Picking #9768

Motivation and Context

Enable adding new actions in the embed mode without touching the layout of files app.

How Has This Been Tested?

test environment: local dev env
test case 1: create a new element in files app and use portal to teleport it into the footer

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests

Checklist:

Code changes
Unit tests added
Acceptance tests added
Documentation ticket raised:

update-docs · 2023-10-16T14:36:59Z

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

LukasHirt · 2023-10-16T14:42:56Z

@JammingBen @dschmidt ping for review :)

If you have any hints/requirements about specific automated tests, please, let me know. Otherwise my plan is to do an E2E test in files app once the footer is implemented there to ensure the portal works...

JammingBen · 2023-10-16T15:14:22Z

If you have any hints/requirements about specific automated tests, please, let me know. Otherwise my plan is to do an E2E test in files app once the footer is implemented there to ensure the portal works...

Actually we plan to have e2e tests for core functionality only. Hence I'd suggest not to worry about them - at least for now. Unit tests on the other hand are always welcome (though I don't know if it makes sense for a portal 😅 ).