Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests-only] Reenable upload related tests #3457

Merged
merged 1 commit into from
May 21, 2020
Merged

[Tests-only] Reenable upload related tests #3457

merged 1 commit into from
May 21, 2020

Conversation

PVince81
Copy link
Contributor

Reverts #3443, the problem should be fixed through cs3org/reva#734 which was updated in ocis-reva through owncloud/ocis-reva#192

@PVince81 PVince81 requested a review from dpakach May 13, 2020 07:33
@PVince81 PVince81 self-assigned this May 13, 2020
@PVince81 PVince81 mentioned this pull request May 13, 2020
Merged
10 tasks
@PVince81
Copy link
Contributor Author

Fixes owncloud/ocis-reva#188

@PVince81
Copy link
Contributor Author

PVince81 commented May 13, 2020 •
edited
Loading

Seems there are other issues related to upload to look into:

  • webUIUpload/uploadEdgecases.feature
  • webUIUpload/upload.feature

@PVince81
Copy link
Contributor Author

I'll try and isolate these and then we can at least unskip the ones that are already passing now

@PVince81
Copy link
Contributor Author

PVince81 commented May 13, 2020 •
edited
Loading

  • likely related to conflict management / overwrite with TUS:

  • folder upload issues

    • tests/acceptance/features/webUIUpload/upload.feature:45: solved by fixing folder existence check
    • tests/acceptance/features/webUIUpload/upload.feature:31: solved by fixing folder existence check
    • tests/acceptance/features/webUIUpload/upload.feature:19: raised as TUS folder upload issues #3458

@PVince81
Copy link
Contributor Author

so apparently I ran all tests on master and forgot to skip the OCIS ones.
anyway, I looked into the above and saw that some can further be enabled and did so.

I've disabled a few more related to overwrite and folder upload.

@PVince81 PVince81 mentioned this pull request May 13, 2020
Closed
@PVince81
Copy link
Contributor Author

Fixes owncloud/ocis-reva#106

@PVince81 PVince81 changed the title Revert "[Tests-Only]Skip failing tests in ocis" Reenable upload related tests May 13, 2020
@PVince81 PVince81 changed the title Reenable upload related tests Reenable upload related OCIS tests May 13, 2020
@PVince81 PVince81 changed the title Reenable upload related OCIS tests [Tests-only] Reenable upload related tests May 13, 2020
@PVince81 PVince81 force-pushed the revert-3443-skip-tests-fail branch from c80f5f0 to 2df8ef1 Compare May 13, 2020 09:44
@PVince81
Copy link
Contributor Author

still 11 failures, it's as if my changes didn't matter at all...

and for some reason the test results summary is not appearing, so I have to cherry-pick the results from the log...

  1. Scenario: simple upload of a file that does not exist before (attempt 2) # tests/acceptance/features/webUIUpload/upload.feature:12
  2. Scenario: simple upload of a folder that does not exist before (attempt 2) # tests/acceptance/features/webUIUpload/upload.feature:31
  3. Scenario: Upload of a folder inside a subdirectory (attempt 2) # tests/acceptance/features/webUIUpload/upload.feature:45
  4. Scenario: uploading a big file (when chunking is implemented this upload should be chunked) (attempt 2) # tests/acceptance/features/webUIUpload/upload.feature:60
  5. Scenario: upload a new file into a sub folder (attempt 2) # tests/acceptance/features/webUIUpload/upload.feature:76
  6. Scenario: overwrite an existing file (attempt 1, retried) # tests/acceptance/features/webUIUpload/upload.feature:84
  7. Scenario: overwrite an existing file in a sub-folder (attempt 1, retried) # tests/acceptance/features/webUIUpload/upload.feature:125
  8. Scenario: upload a new file into a sub folder (attempt 1, retried) # tests/acceptance/features/webUIUpload/uploadEdgecases.feature:46
  9. Scenario: upload a new file into a sub folder (attempt 1, retried) # tests/acceptance/features/webUIUpload/uploadEdgecases.feature:47
  10. Scenario: Upload a big file called "0" (when chunking in implemented that upload should be chunked) (attempt 1, retried) # tests/acceptance/features/webUIUpload/uploadEdgecases.feature:115
  11. Scenario: Upload a file with the same name as already existing folder (attempt 1, retried) # tests/acceptance/features/webUIUpload/uploadEdgecases.feature:139

Sadly, all these tests pass locally for me with ocis master a1da513f74b9ddfe1790f534169edf32b5e4c8b9 Using: chrome (76.0.3809.87) on Linux platform.

Sometimes I see this:

√ Element <#files-file-upload-button> was visible after 28 milliseconds.
Timed out while waiting for element <#files-upload-progress> to be visible for 10000 milliseconds. - expected "visible" but got: "not visible" (10017ms)
undefined√ Element <#files-upload-progress> was not visible after 19 milliseconds.

or

    And the user browses to the files page
Timed out while waiting for element <#files-list-progress> to be present for 10000 milliseconds. - expected "found" but got: "not found" (10012ms)
undefined√ Element <#files-list-progress> was not present after 10 milliseconds.

But when I look at VNC I see that the page is already loaded.
I wonder if ocis is so fast that we don't have time to detect the progress bar at all ??
In any case it seems that waiting for the progress bar is looking for trouble, potential timing issues. I suggest we adjust the test code to not rely on the progress bar but on the final result if possible.

White the tests appear green locally, it seems on CI it's stricter and considers these timeouts as failure.

@dpakach @individual-it can you have a look at that part and adjust the test code for not relying on the progress bar ?

@PVince81 PVince81 mentioned this pull request May 13, 2020
Merged
@PVince81
Copy link
Contributor Author

I made another PR that only reenables the tests that already pass on CI, just to move forward: #3461

@dpakach dpakach force-pushed the revert-3443-skip-tests-fail branch from adfcbc4 to 7451e79 Compare May 15, 2020 05:52
@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIOCIS failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/9722/

20200515-063927-940.png
20200515-063952-311.png
20200515-064017-038.png
20200515-064041-557.png
20200515-064109-279.png
20200515-064134-950.png
20200515-064159-924.png
20200515-064224-991.png
20200515-064251-047.png
20200515-064317-018.png
20200515-064325-988.png
20200515-064335-490.png
20200515-064344-981.png
20200515-064354-316.png
20200515-064419-726.png
20200515-064445-465.png
20200515-064531-370.png
20200515-064558-001.png
20200515-064643-935.png
20200515-064710-600.png
20200515-064755-845.png
20200515-064822-116.png
20200515-064907-392.png
20200515-064933-477.png
20200515-065000-953.png
20200515-065028-167.png
20200515-065117-802.png
20200515-065207-158.png

@dpakach
Copy link
Contributor

dpakach commented May 15, 2020

the upload is just stuck at 0% , the progress bar doesn't disappears. Not sure why this is happening.

@PVince81
Copy link
Contributor Author

@dpakach strange. in my observation, as far as I remember, the operation already completed successfully without the progress bar appearing at all (maybe very fast). At least in my local tests.

@dpakach
Copy link
Contributor

dpakach commented May 15, 2020

@PVince81 I run with screenshots in CI just now you can check them in #3457 (comment)
But it's strange indeed.

@dpakach dpakach force-pushed the revert-3443-skip-tests-fail branch from 9c89269 to 2136a5e Compare May 18, 2020 04:41
@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIOCIS failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/9748/

20200518-050237-420.png
20200518-050306-118.png
20200518-050334-933.png
20200518-050403-360.png
20200518-050433-676.png
20200518-050504-382.png
20200518-050533-582.png
20200518-050603-702.png
20200518-050636-713.png
20200518-050706-434.png
20200518-050717-265.png
20200518-050727-945.png
20200518-050739-580.png
20200518-050751-290.png
20200518-050818-746.png
20200518-050905-048.png
20200518-050953-108.png
20200518-051022-119.png
20200518-051110-026.png
20200518-051138-926.png
20200518-051206-999.png
20200518-051254-161.png
20200518-051322-189.png
20200518-051409-565.png
20200518-051458-540.png
20200518-051547-998.png
20200518-051620-546.png
20200518-051652-875.png

@dpakach dpakach force-pushed the revert-3443-skip-tests-fail branch from 2136a5e to dd547a1 Compare May 18, 2020 05:29
@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIOCIS failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/9750/

20200518-054839-352.png
20200518-054904-604.png

@dpakach dpakach force-pushed the revert-3443-skip-tests-fail branch from dd547a1 to 62b4f11 Compare May 18, 2020 05:53
@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIOCIS failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/9751/

20200518-061011-734.png
20200518-061039-522.png

@PVince81
Copy link
Contributor Author

we should remove the ".gitignore" commit. I had some weird local files in that folder (maybe from download tests) and falsely believed that the whole folder must be excluded

@PVince81 PVince81 mentioned this pull request May 18, 2020
Merged
@PVince81
Copy link
Contributor Author

I've extracted the folder check commit to #3473.
Hopefully if that passes it will be one less worry.

@dpakach
Copy link
Contributor

dpakach commented May 19, 2020

@PVince81 I tried this by running drone locally, and get this log in browser

core.bundle.js:83 HEAD http://localhost:9164/data/d6636d01-d64d-498d-80cd-5a65e360acf8 net::ERR_CONNECTION_REFUSED

It tries to connect to localhost for the data even when reva is running in completley different host. This might be the reason for failing tests.

@PVince81
Copy link
Contributor Author

@dpakach this could be a setup thing, not sure how to adjust it.

Note: this was not relevant before TUS since we didn't need to connect to the storage service directly and is now becoming relevant with the introduction of TUS. So we'll need to adjust the config.

@butonic

@PVince81 PVince81 mentioned this pull request May 19, 2020
Closed
@PVince81
Copy link
Contributor Author

PVince81 commented May 19, 2020 •
edited
Loading

that's the service "reva-storage-oc-data"

need to set REVA_STORAGE_OC_DATA_URL (https://github.com/owncloud/ocis-reva/blob/master/pkg/flagset/storageocdata.go#L116) to specify the correct URL

@PVince81 PVince81 mentioned this pull request May 19, 2020
Closed
@PVince81
Copy link
Contributor Author

I pushed a fix, let's see if this works.

Also, a similar fix for ocis-reva: owncloud/ocis-reva#213

@PVince81
Copy link
Contributor Author

still failing :-/

  1. Scenario: simple upload of a file that does not exist before (attempt 2) # tests/acceptance/features/webUIUpload/upload.feature:13

@PVince81
Copy link
Contributor Author

wait, I didn't push...

@PVince81
Copy link
Contributor Author

pushed now (had local conflict and went away for lunch after pushing and missed the error message locally...)

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIOCIS failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/9763/

20200519-143528-033.png
20200519-143557-292.png

@PVince81
Copy link
Contributor Author

indeed the same issue as before...

1) Scenario: simple upload of a file that does not exist before (attempt 1, retried) # tests/acceptance/features/webUIUpload/upload.feature:13

@dpakach dpakach force-pushed the revert-3443-skip-tests-fail branch 2 times, most recently from 2c42c42 to 3f8792e Compare May 21, 2020 06:36
@dpakach dpakach force-pushed the revert-3443-skip-tests-fail branch from 3f8792e to be87983 Compare May 21, 2020 08:12
@individual-it individual-it merged commit a720cb4 into master May 21, 2020
@delete-merged-branch delete-merged-branch bot deleted the revert-3443-skip-tests-fail branch May 21, 2020 10:48
@PVince81
Copy link
Contributor Author

seems now we have issues again, even with latest reva: https://cloud.drone.io/owncloud/ocis-reva/376/3/11 from owncloud/ocis-reva#221

@PVince81 PVince81 mentioned this pull request May 22, 2020
Closed
@PVince81
Copy link
Contributor Author

raised #3492 to look into this.
it's blocking owncloud/ocis-reva#215

@dpakach dpakach mentioned this pull request May 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@individual-it individual-it individual-it approved these changes

@dpakach dpakach Awaiting requested review from dpakach

Assignees

@PVince81 PVince81

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PVince81 @ownclouders @dpakach @individual-it