refactor: use ids for copy and move operations #11199
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
JammingBen
force-pushed
the
refactor/copy-move-id-based
branch
from
319ebcb
to
bcfa1de
Compare
|
This solution currently doesn't work on public pages because we still need to work with paths on those. We could introduce checks and keep supporting paths and ids, but I don't really like this. Maybe owncloud/ocis#9623 gets resolved in the near future, then we can omit paths completely for copy- and move-operations. |
JammingBen
force-pushed
the
refactor/copy-move-id-based
branch
from
dfa4a9c
to
fe10f21
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per title.
Also fixes as issue where
listFileswith only a space provided would fail. The webdav path now falls back to the space webdav path if nopathorfileIdare being provided.Related Issue
Types of changes