Add share file with link expiration #292
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this expands on #287 (I wasn't sure how to modify the existing PR...).
This PR includes the following:
When running the test suite TestPublicFolder.test_from_link kept failing with the error
TypeError: can only concatenate str (not "int") to str
due to line 401 so I added str(public_link_components.port).This PR closes #287 and it closes #289.
Edit. I just noticed the last point is addressed by issue #291. So this PR overlaps and also closes #290 and closes #291.