Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add collabora extra param #9716

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Conversation

ScharfViktor
Copy link
Contributor

this fix can help to solve this issue #9706 (comment) with local running collabora v.24

related owncloud/web#11301

@ScharfViktor ScharfViktor requested a review from micbar July 30, 2024 14:06
Copy link

update-docs bot commented Jul 30, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@micbar
Copy link
Contributor

micbar commented Jul 30, 2024

We need to create an env var for this in the .env file because we should not set the default to insecure.

Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the default secure.

@ScharfViktor ScharfViktor requested a review from micbar July 30, 2024 20:31
Copy link

sonarcloud bot commented Jul 30, 2024

@ScharfViktor ScharfViktor merged commit f7f0496 into master Jul 31, 2024
2 checks passed
@micbar micbar deleted the addNeededCollaboraExtraParam branch July 31, 2024 06:15
ownclouders pushed a commit that referenced this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants